Skip to content

Commit 5739393

Browse files
committed
Check to make sure settings exist before attempting to update them
1 parent 1395625 commit 5739393

File tree

1 file changed

+16
-14
lines changed

1 file changed

+16
-14
lines changed

database/migrations/2025_05_20_190317_repopulate_webhook_selected_setting.php

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -11,21 +11,23 @@ public function up(): void
1111
{
1212
$settings = DB::table('settings')->first();
1313

14-
/** If webhook settings were cleared via the integration settings page,
15-
* the webhook_selected was cleared as well when it should have reset to "slack".
16-
*/
17-
if (
18-
empty($settings->webhook_selected) &&
19-
(empty($settings->webhook_botname) && empty($settings->webhook_channel) && empty($settings->webhook_endpoint))
20-
) {
21-
DB::table('settings')->update(['webhook_selected' => 'slack']);
22-
}
14+
if ($settings) {
15+
/** If webhook settings were cleared via the integration settings page,
16+
* the webhook_selected was cleared as well when it should have reset to "slack".
17+
*/
18+
if (
19+
empty($settings->webhook_selected) &&
20+
(empty($settings->webhook_botname) && empty($settings->webhook_channel) && empty($settings->webhook_endpoint))
21+
) {
22+
DB::table('settings')->update(['webhook_selected' => 'slack']);
23+
}
2324

24-
/** If webhook settings were cleared via the integration settings page,
25-
* then slack settings were re-added; then webhook_selected was not being set to "slack" as needed.
26-
*/
27-
if (str_contains($settings->webhook_endpoint, 'slack.com')) {
28-
DB::table('settings')->update(['webhook_selected' => 'slack']);
25+
/** If webhook settings were cleared via the integration settings page,
26+
* then slack settings were re-added; then webhook_selected was not being set to "slack" as needed.
27+
*/
28+
if (str_contains($settings->webhook_endpoint, 'slack.com')) {
29+
DB::table('settings')->update(['webhook_selected' => 'slack']);
30+
}
2931
}
3032
}
3133

0 commit comments

Comments
 (0)