Merge pull request #12049 from uberbrady/improve_scim_externalid_support

Fixed writes to the `externalId` from SCIM

Author: snipe

app/Models/SnipeSCIMConfig.php

@@ -41,8 +41,10 @@ function (&$object) {
             } 
         );
 
-        $config['validations'][$core.'externalId'] = 'string'; // not required, but supported mostly just for Okta
-        $mappings['externalId'] = AttributeMapping::eloquent('scim_externalid');
+        // externalId support
+        $config['validations'][$core.'externalId'] = 'string|nullable'; // not required, but supported mostly just for Okta
+        // note that the mapping is *not* namespaced like the other $mappings
+        $config['mapping']['externalId'] = AttributeMapping::eloquent('scim_externalid');
 
         $config['validations'][$core.'emails'] = 'nullable|array';         // emails are not required in Snipe-IT...
         $config['validations'][$core.'emails.*.value'] = 'email'; // ...(had to remove the recommended 'required' here)

app/Models/User.php

@@ -61,6 +61,7 @@ class User extends SnipeModel implements AuthenticatableContract, AuthorizableCo
         'remote',
         'start_date',
         'end_date',
+        'scim_externalid'
     ];
 
     protected $casts = [