Merge pull request #16658 from snipe/fix_bad_data_on_permission_groups

snipe · web-flow · commit 7448f67e1256 · 2025-04-08T07:10:02.000+01:00
Set empty array if group permission is a string or null
diff --git a/app/Http/Controllers/GroupsController.php b/app/Http/Controllers/GroupsController.php
@@ -83,6 +83,10 @@ public function edit(Group $group) : View | RedirectResponse
     {
         $permissions = config('permissions');
         $groupPermissions = $group->decodePermissions();
+
+        if ((!is_array($groupPermissions)) || (!$groupPermissions)) {
+            $groupPermissions = [];
+        }
         $selected_array = Helper::selectedPermissionsArray($permissions, $groupPermissions);
         return view('groups.edit', compact('group', 'permissions', 'selected_array', 'groupPermissions'));
     }

Original file line number	Diff line number	Diff line change
`@@ -83,6 +83,10 @@ public function edit(Group $group) : View \| RedirectResponse`
`83`	`83`	`{`
`84`	`84`	`$permissions = config('permissions');`
`85`	`85`	`$groupPermissions = $group->decodePermissions();`
	`86`	`+`
	`87`	`+ if ((!is_array($groupPermissions)) \|\| (!$groupPermissions)) {`
	`88`	`+ $groupPermissions = [];`
	`89`	`+ }`
`86`	`90`	`$selected_array = Helper::selectedPermissionsArray($permissions, $groupPermissions);`
`87`	`91`	`return view('groups.edit', compact('group', 'permissions', 'selected_array', 'groupPermissions'));`
`88`	`92`	`}`