Nicer query

snipe · snipe · commit 7a1ccb0d53df · 2025-11-23T14:09:55.000Z
diff --git a/app/Http/Controllers/Api/LicenseSeatsController.php b/app/Http/Controllers/Api/LicenseSeatsController.php
@@ -80,7 +80,7 @@ public function show($licenseId, $seatId) : JsonResponse | array
 
         $this->authorize('view', License::class);
 
-        if ($licenseSeat = LicenseSeat::where('id',$seatId)->where('license_id', $licenseId)->first()) {
+        if ($licenseSeat = LicenseSeat::where('license_id', $licenseId)->find($seatId)) {
             return (new LicenseSeatsTransformer)->transformLicenseSeat($licenseSeat);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ public function show($licenseId, $seatId) : JsonResponse \| array`
`80`	`80`
`81`	`81`	`$this->authorize('view', License::class);`
`82`	`82`
`83`		`- if ($licenseSeat = LicenseSeat::where('id',$seatId)->where('license_id', $licenseId)->first()) {`
	`83`	`+ if ($licenseSeat = LicenseSeat::where('license_id', $licenseId)->find($seatId)) {`
`84`	`84`	`return (new LicenseSeatsTransformer)->transformLicenseSeat($licenseSeat);`
`85`	`85`	`}`
`86`	`86`