Skip to content

Commit 89f439a

Browse files
committed
Shows success message on partial bulk delete success
1 parent 79eb5bf commit 89f439a

File tree

6 files changed

+23
-4
lines changed

6 files changed

+23
-4
lines changed

app/Http/Controllers/BulkCategoriesController.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ public function destroy(Request $request)
1919
$this->authorize('delete', Category::class);
2020

2121
$errors = [];
22+
$success_count = 0;
23+
2224
foreach ($request->ids as $id) {
2325
$category = Category::find($id);
2426
if (is_null($category)) {
@@ -27,6 +29,7 @@ public function destroy(Request $request)
2729
}
2830
try {
2931
DestroyCategoryAction::run(category: $category);
32+
$success_count++;
3033
} catch (ItemStillHasAccessories $e) {
3134
$errors[] = trans('general.bulk_delete_associations.assoc_assets_no_count', ['item_name' => $category->name, 'item' => trans('general.category')]);
3235
} catch (ItemStillHasAssetModels) {
@@ -45,6 +48,9 @@ public function destroy(Request $request)
4548
}
4649
}
4750
if (count($errors) > 0) {
51+
if ($success_count > 0) {
52+
return redirect()->route('categories.index')->with('success', trans_choice('admin/categories/message.delete.partial_success', $success_count, ['count' => $success_count]))->with('multi_error_messages', $errors);
53+
}
4854
return redirect()->route('categories.index')->with('multi_error_messages', $errors);
4955
} else {
5056
return redirect()->route('categories.index')->with('success', trans('admin/categories/message.delete.bulk_success'));

app/Http/Controllers/BulkManufacturersController.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ public function destroy(Request $request)
2020
$this->authorize('delete', Manufacturer::class);
2121

2222
$errors = [];
23+
$success_count = 0;
2324
foreach ($request->ids as $id) {
2425
$manufacturer = Manufacturer::find($id);
2526
if (is_null($manufacturer)) {
@@ -28,6 +29,7 @@ public function destroy(Request $request)
2829
}
2930
try {
3031
DeleteManufacturerAction::run(manufacturer: $manufacturer);
32+
$success_count++;
3133
} catch (ItemStillHasAssets $e) {
3234
$errors[] = trans('general.bulk_delete_associations.assoc_assets_no_count', ['item_name' => $manufacturer->name, 'item' => trans('general.manufacturer')]);
3335
} catch (ItemStillHasAccessories $e) {
@@ -44,6 +46,9 @@ public function destroy(Request $request)
4446
}
4547
}
4648
if (count($errors) > 0) {
49+
if ($success_count > 0) {
50+
return redirect()->route('manufacturers.index')->with('success', trans_choice('admin/manufacturers/message.delete.partial_success', $success_count, ['count' => $success_count]))->with('multi_error_messages', $errors);
51+
}
4752
return redirect()->route('manufacturers.index')->with('multi_error_messages', $errors);
4853
} else {
4954
return redirect()->route('manufacturers.index')->with('success', trans('admin/manufacturers/message.delete.bulk_success'));

app/Http/Controllers/BulkSuppliersController.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ public function destroy(Request $request)
1919
$this->authorize('delete', Supplier::class);
2020

2121
$errors = [];
22+
$success_count = 0;
23+
2224
foreach ($request->ids as $id) {
2325
$supplier = Supplier::find($id);
2426
if (is_null($supplier)) {
@@ -45,6 +47,9 @@ public function destroy(Request $request)
4547
}
4648
}
4749
if (count($errors) > 0) {
50+
if ($success_count > 0) {
51+
return redirect()->route('suppliers.index')->with('success', trans_choice('admin/suppliers/message.delete.partial_success', $success_count, ['count' => $success_count]))->with('multi_error_messages', $errors);
52+
}
4853
return redirect()->route('suppliers.index')->with('multi_error_messages', $errors);
4954
} else {
5055
return redirect()->route('suppliers.index')->with('success', trans('admin/suppliers/message.delete.bulk_success'));

resources/lang/en-US/admin/categories/message.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,9 @@
2020
'delete' => array(
2121
'confirm' => 'Are you sure you wish to delete this category?',
2222
'error' => 'There was an issue deleting the category. Please try again.',
23-
'success' => 'The category was deleted successfully.',
24-
'bulk_success' => 'The Categories were deleted successfully.',
23+
'success' => 'Category was deleted successfully.',
24+
'bulk_success' => 'Categories were deleted successfully.',
25+
'partial_success' => 'Category deleted successfully. See additional information below. | :count categories were deleted successfully. See additional information below.',
2526
)
2627

2728
);

resources/lang/en-US/admin/manufacturers/message.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,9 @@
2424
'delete' => array(
2525
'confirm' => 'Are you sure you wish to delete this manufacturer?',
2626
'error' => 'There was an issue deleting the manufacturer. Please try again.',
27-
'success' => 'The Manufacturer was deleted successfully.',
28-
'bulk_success' => 'The Manufacturers were deleted successfully.',
27+
'success' => 'Manufacturer deleted successfully.',
28+
'bulk_success' => 'Manufacturers deleted successfully.',
29+
'partial_success' => 'Manufacturer deleted successfully. See additional information below. | :count manufacturers were deleted successfully. See additional information below.',
2930
)
3031

3132
);

resources/lang/en-US/admin/suppliers/message.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
'success' => 'Supplier was deleted successfully.',
2323
'not_found' => 'Supplier not found.',
2424
'bulk_success' => 'Suppliers were deleted successfully.',
25+
'partial_success' => 'Supplier deleted successfully. See additional information below. | :count suppliers were deleted successfully. See additional information below.',
2526
)
2627

2728
);

0 commit comments

Comments
 (0)