next round of codacy improvements

Author: JonasGoseberg

app/Services/PredefinedFilterService.php

@@ -11,6 +11,7 @@
 use App\Models\Supplier;
 use DB;
 use Exception;
+use Log;
 use Throwable;
 use App\Models\PredefinedFilter;
 use App\Services\FilterService\FilterService;
@@ -194,7 +195,7 @@ public function updateFilter(PredefinedFilter $filter, array $validated): Predef
                 });
             } catch (Throwable $e) {
                 // If any exception occurs, the transaction is automatically rolled back.
-                throw new Exception($e->getMessage());
+                Log::error($e->getMessage());
             }
         }
 

database/seeders/DatabaseSeeder.php

@@ -36,9 +36,6 @@ public function run()
         $this->call(DepreciationSeeder::class);
         $this->call(StatuslabelSeeder::class);
         $this->call(AccessorySeeder::class);
-
-        $dataset = env('TEST_DATASET', 'default');
-
         $this->call(CustomFieldSeeder::class);
 
         $this->call(AssetSeeder::class);

resources/assets/js/advancedSearch/apiService.js

@@ -28,7 +28,8 @@ export default class ApiService {
             return Promise.reject(new Error(`Invalid id ${id}. Must be a positive integer.`));
         }
 
-        const path = `${this.baseUrl}/${typeMap[type]}/${id}`;
+        const safeType = String(type);
+        const path = `${this.baseUrl}/${safeType}/${id}`;
         return this.fetchFromBackend('GET', path);
     }
 

resources/assets/js/advancedSearch/filterFormManager.js

@@ -1,5 +1,4 @@
 import {
-    FilterInput,
     SelectFilterInput,
     AssignedEntityFilterInput,
     DateFilterInput,
@@ -115,7 +114,7 @@ export default class FilterFormManager {
         queueMicrotask(() => {
             const fields = document.getElementById("advancedSearchPanel").getElementsByTagName('*');
             for (let i = 0; i < fields.length; i++) {
-                fields[i].disabled = state;
+                fields[i].disabled = !!state;
             }
         });
     }

resources/assets/js/advancedSearch/floating-buttons.js

@@ -373,7 +373,7 @@ export default class FloatingButtons {
                     this.fabMenu && this.fabMenu.setAttribute('aria-hidden', 'false');
                     this.menuToggleButton?.setAttribute('aria-expanded', 'true');
 
-                    this.menuItems?.forEach((item, idx) => {
+                    this.menuItems?.forEach((item) => {
                         item.setAttribute('tabindex', '0');
                     });
                     this.menuItems?.[0]?.focus();

tests/TestCase.php

@@ -28,7 +28,6 @@ abstract class TestCase extends BaseTestCase
     use LazilyRefreshDatabase;
     use AssertHasActionLogs;
 
-
     private array $globallyDisabledMiddleware = [
         SecurityHeaders::class,
     ];