Skip to content

Commit a9574e8

Browse files
committed
Fixed #18133 - make the disabled toggle JS so it’s clearer
1 parent c6269d6 commit a9574e8

File tree

1 file changed

+25
-9
lines changed

1 file changed

+25
-9
lines changed

resources/views/settings/asset_tags.blade.php

Lines changed: 25 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
{{csrf_field()}}
2727

2828
<div class="row">
29-
<div class="col-sm-10 col-sm-offset-1 col-md-8 col-md-offset-2">
29+
<div class="col-md-8 col-md-offset-2 col-lg-6 col-lg-offset-3">
3030

3131

3232
<div class="panel box box-default">
@@ -38,13 +38,13 @@
3838
<div class="box-body">
3939

4040

41-
<div class="col-md-11 col-md-offset-1">
41+
<div class="col-md-12">
4242

4343
<!-- auto ids -->
4444
<div class="form-group">
4545
<div class="col-md-8 col-md-offset-3">
4646
<label class="form-control">
47-
<input type="checkbox" name="auto_increment_assets" value="1" @checked(old('auto_increment_assets', $setting->auto_increment_assets)) aria-label="auto_increment_assets">
47+
<input type="checkbox" id="auto_increment_assets" name="auto_increment_assets" value="1" @checked(old('auto_increment_assets', $setting->auto_increment_assets)) aria-label="auto_increment_assets">
4848
{{ trans('admin/settings/general.auto_increment_assets') }}
4949
</label>
5050
</div>
@@ -67,12 +67,9 @@
6767
<label for="auto_increment_prefix" class="col-md-3 control-label">{{ trans('admin/settings/general.auto_increment_prefix') }}</label>
6868

6969
<div class="col-md-8">
70-
@if ($setting->auto_increment_assets == 1)
71-
<input class="form-control" maxlength="100" style="width: 200px;" aria-label="auto_increment_prefix" name="auto_increment_prefix" type="text" id="auto_increment_prefix" value="{{ old('auto_increment_prefix', $setting->auto_increment_prefix) }}">
72-
{!! $errors->first('auto_increment_prefix', '<span class="alert-msg" aria-hidden="true">:message</span>') !!}
73-
@else
74-
<input class="form-control" maxlength="100" disabled="disabled" style="width: 200px;" aria-label="auto_increment_prefix" name="auto_increment_prefix" type="text" id="auto_increment_prefix" value="{{ old('auto_increment_prefix', $setting->auto_increment_prefix) }}">
75-
@endif
70+
<input class="form-control" disabled maxlength="100" style="width: 200px;" aria-label="auto_increment_prefix" name="auto_increment_prefix" type="text" id="auto_increment_prefix" value="{{ old('auto_increment_prefix', $setting->auto_increment_prefix) }}">
71+
{!! $errors->first('auto_increment_prefix', '<span class="alert-msg" aria-hidden="true">:message</span>') !!}
72+
7673
</div>
7774
</div>
7875

@@ -105,4 +102,23 @@
105102

106103
</form>
107104

105+
@section('moar_scripts')
106+
<script>
107+
if ($("#auto_increment_assets").is(':checked')) {
108+
// Hide here instead of fadeout on pageload to prevent what looks like Flash Of Unstyled Content (FOUC)
109+
$("#auto_increment_prefix").prop('disabled', false);
110+
}
111+
112+
$("#auto_increment_assets").change(function () {
113+
114+
if ($("#auto_increment_assets").is(':checked')) {
115+
$("#auto_increment_prefix").prop('disabled', false);
116+
} else {
117+
$("#auto_increment_prefix").prop('disabled', true);
118+
}
119+
});
120+
</script>
121+
@endsection
122+
123+
108124
@stop

0 commit comments

Comments
 (0)