Skip to content

Commit bf344e9

Browse files
committed
Merge branch 'develop'
2 parents fb180d7 + f66e222 commit bf344e9

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

app/Http/Controllers/Api/AccessoriesController.php

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
use App\Helpers\Helper;
88
use App\Models\Accessory;
99
use App\Http\Transformers\AccessoriesTransformer;
10+
use App\Models\Company;
1011

1112

1213
class AccessoriesController extends Controller
@@ -128,9 +129,15 @@ public function accessory_detail($id)
128129
public function checkedout($id)
129130
{
130131
$this->authorize('view', Accessory::class);
131-
$accessory = Accessory::findOrFail($id)->with('users')->first();
132-
$total = $accessory->users->count();
133-
return (new AccessoriesTransformer)->transformCheckedoutAccessory($accessory, $total);
132+
133+
$accessory = Accessory::findOrFail($id);
134+
if (!Company::isCurrentUserHasAccess($accessory)) {
135+
return ['total' => 0, 'rows' => []];
136+
}
137+
$accessory_users = $accessory->users;
138+
$total = $accessory_users->count();
139+
140+
return (new AccessoriesTransformer)->transformCheckedoutAccessory($accessory_users, $total);
134141
}
135142

136143

app/Http/Transformers/AccessoriesTransformer.php

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,14 +59,12 @@ public function transformAccessory (Accessory $accessory)
5959
}
6060

6161

62-
public function transformCheckedoutAccessory (Accessory $accessory, $total)
62+
public function transformCheckedoutAccessory ($accessory_users, $total)
6363
{
6464

6565

66-
67-
6866
$array = array();
69-
foreach ($accessory->users as $user) {
67+
foreach ($accessory_users as $user) {
7068
$array[] = [
7169
'assigned_pivot_id' => $user->pivot->id,
7270
'id' => (int) $user->id,

0 commit comments

Comments
 (0)