Skip to content

Commit c45e777

Browse files
committed
Merge remote-tracking branch 'origin/develop'
2 parents 52e33a8 + 53499b1 commit c45e777

File tree

8 files changed

+32
-14
lines changed

8 files changed

+32
-14
lines changed

app/Http/Controllers/Accessories/AccessoriesFilesController.php

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,16 @@ class AccessoriesFilesController extends Controller
2727
*/
2828
public function store(AssetFileRequest $request, $accessoryId = null)
2929
{
30+
31+
if (config('app.lock_passwords')) {
32+
return redirect()->route('accessories.show', ['accessory'=>$accessoryId])->with('error', trans('general.feature_disabled'));
33+
}
34+
35+
3036
$accessory = Accessory::find($accessoryId);
3137

3238
if (isset($accessory->id)) {
33-
$this->authorize('update', $accessory);
39+
$this->authorize('accessories.files', $accessory);
3440

3541
if ($request->hasFile('file')) {
3642
if (! Storage::exists('private_uploads/accessories')) {
@@ -129,9 +135,12 @@ public function destroy($accessoryId = null, $fileId = null)
129135
*/
130136
public function show($accessoryId = null, $fileId = null, $download = true)
131137
{
138+
132139
\Log::debug('Private filesystem is: '.config('filesystems.default'));
133140
$accessory = Accessory::find($accessoryId);
134141

142+
143+
135144
// the accessory is valid
136145
if (isset($accessory->id)) {
137146
$this->authorize('view', $accessory);

app/Http/Controllers/AssetModelsFilesController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public function store(AssetFileRequest $request, $modelId = null)
6262
$model->logUpload($file_name, e($request->get('notes')));
6363
}
6464

65-
return redirect()->back()->with('success', trans('admin/hardware/message.upload.success'));
65+
return redirect()->back()->with('success', trans('general.file_upload_success'));
6666
}
6767

6868
return redirect()->back()->with('error', trans('admin/hardware/message.upload.nofiles'));

app/Http/Controllers/Components/ComponentsFilesController.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,11 @@ class ComponentsFilesController extends Controller
2727
*/
2828
public function store(AssetFileRequest $request, $componentId = null)
2929
{
30+
31+
if (config('app.lock_passwords')) {
32+
return redirect()->route('components.show', ['component'=>$componentId])->with('error', trans('general.feature_disabled'));
33+
}
34+
3035
$component = Component::find($componentId);
3136

3237
if (isset($component->id)) {

app/Http/Controllers/Consumables/ConsumablesFilesController.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,10 @@ class ConsumablesFilesController extends Controller
2727
*/
2828
public function store(AssetFileRequest $request, $consumableId = null)
2929
{
30+
if (config('app.lock_passwords')) {
31+
return redirect()->route('consumables.show', ['consumable'=>$consumableId])->with('error', trans('general.feature_disabled'));
32+
}
33+
3034
$consumable = Consumable::find($consumableId);
3135

3236
if (isset($consumable->id)) {

resources/views/accessories/view.blade.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272
</li>
7373

7474

75-
@can('accessorys.files', $accessory)
75+
@can('accessories.files', $accessory)
7676
<li>
7777
<a href="#files" data-toggle="tab">
7878
<span class="hidden-lg hidden-md">
@@ -176,7 +176,7 @@ class="table table-striped snipe-table"
176176

177177

178178

179-
@can('accessorys.files', $accessory)
179+
@can('accessories.files', $accessory)
180180
<div class="tab-pane" id="files">
181181

182182
<div class="table table-responsive">
@@ -198,7 +198,7 @@ class="table table-striped snipe-table"
198198
data-sort-name="name"
199199
class="table table-striped snipe-table"
200200
data-export-options='{
201-
"fileName": "export-accessorys-uploads-{{ str_slug($accessory->name) }}-{{ date('Y-m-d') }}",
201+
"fileName": "export-accessories-uploads-{{ str_slug($accessory->name) }}-{{ date('Y-m-d') }}",
202202
"ignoreColumn": ["actions","image","change","checkbox","checkincheckout","delete","download","icon"]
203203
}'>
204204
<thead>
@@ -224,16 +224,16 @@ class="table table-striped snipe-table"
224224
</td>
225225
<td>
226226
@if ($file->filename)
227-
@if ( Helper::checkUploadIsImage($file->get_src('accessorys')))
227+
@if ( Helper::checkUploadIsImage($file->get_src('accessories')))
228228
<a href="{{ route('show.accessoryfile', ['accessoryId' => $accessory->id, 'fileId' => $file->id, 'download' => 'false']) }}" data-toggle="lightbox" data-type="image"><img src="{{ route('show.accessoryfile', ['accessoryId' => $accessory->id, 'fileId' => $file->id]) }}" class="img-thumbnail" style="max-width: 50px;"></a>
229229
@endif
230230
@endif
231231
</td>
232232
<td>
233233
{{ $file->filename }}
234234
</td>
235-
<td data-value="{{ (Storage::exists('private_uploads/accessorys/'.$file->filename) ? Storage::size('private_uploads/accessorys/'.$file->filename) : '') }}">
236-
{{ @Helper::formatFilesizeUnits(Storage::exists('private_uploads/accessorys/'.$file->filename) ? Storage::size('private_uploads/accessorys/'.$file->filename) : '') }}
235+
<td data-value="{{ (Storage::exists('private_uploads/accessories/'.$file->filename) ? Storage::size('private_uploads/accessories/'.$file->filename) : '') }}">
236+
{{ @Helper::formatFilesizeUnits(Storage::exists('private_uploads/accessories/'.$file->filename) ? Storage::size('private_uploads/accessories/'.$file->filename) : '') }}
237237
</td>
238238

239239
<td>
@@ -392,7 +392,7 @@ class="table table-striped snipe-table"
392392

393393

394394

395-
@can('update', Accessory::class)
395+
@can('accessories.files', Accessory::class)
396396
@include ('modals.upload-file', ['item_type' => 'accessory', 'item_id' => $accessory->id])
397397
@endcan
398398
@stop

resources/views/components/view.blade.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ class="table table-striped snipe-table"
283283
</div>
284284
</div> <!-- .row-->
285285

286-
@can('update', Component::class)
286+
@can('components.files', Component::class)
287287
@include ('modals.upload-file', ['item_type' => 'component', 'item_id' => $component->id])
288288
@endcan
289289
@stop

resources/views/consumables/view.blade.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@ class="table table-striped snipe-table"
288288
289289
290290
291-
@can('update', \App\Models\Consumable::class)
291+
@can('consumables.files', \App\Models\Consumable::class)
292292
@include ('modals.upload-file', ['item_type' => 'consumable', 'item_id' => $consumable->id])
293293
@endcan
294294
@stop

resources/views/models/view.blade.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,9 +145,9 @@ class="table table-striped snipe-table"
145145
<tr>
146146
<td><i class="{{ Helper::filetype_icon($file->filename) }} icon-med" aria-hidden="true"></i></td>
147147
<td>
148-
@if ( Helper::checkUploadIsImage($file->get_src('assets')))
149-
<a href="{{ route('show/modelFile', ['modelId' => $model->id, 'fileId' =>$file->id]) }}" data-toggle="lightbox" data-type="image" data-title="{{ $file->filename }}" data-footer="{{ Helper::getFormattedDateObject($asset->last_checkout, 'datetime', false) }}">
150-
<img src="{{ route('show/modelfile', ['assetId' => $model->id, 'fileId' =>$file->id]) }}" style="max-width: 50px;">
148+
@if ( Helper::checkUploadIsImage($file->get_src('assetmodels')))
149+
<a href="{{ route('show/modelfile', ['modelID' => $model->id, 'fileId' => $file->id]) }}" data-toggle="lightbox" data-type="image" data-title="{{ $file->filename }}">
150+
<img src="{{ route('show/modelfile', ['modelID' => $model->id, 'fileId' =>$file->id]) }}" style="max-width: 50px;">
151151
</a>
152152
@endif
153153
</td>

0 commit comments

Comments
 (0)