Add redirect for missing template

Author: marcusmoore

app/Http/Controllers/ReportTemplatesController.php

@@ -4,7 +4,6 @@
 
 use App\Models\CustomField;
 use App\Models\ReportTemplate;
-use Illuminate\Contracts\View\View;
 use Illuminate\Http\RedirectResponse;
 use Illuminate\Http\Request;
 
@@ -47,13 +46,20 @@ public function show($reportId)
         ]);
     }
 
-    public function edit($reportId): View
+    public function edit($reportId)
     {
         $this->authorize('reports.view');
 
+        $reportTemplate = ReportTemplate::find($reportId);
+
+        if (!$reportTemplate) {
+            return redirect()->route('reports/custom')
+                ->with('error', trans('admin/reports/message.no_report_permission'));
+        }
+
         return view('reports/custom', [
             'customfields' => CustomField::get(),
-            'template' => ReportTemplate::findOrFail($reportId),
+            'template' => $reportTemplate,
         ]);
     }
 

tests/Feature/ReportTemplates/EditReportTemplateTest.php

@@ -18,8 +18,6 @@ public function testRequiresPermission()
 
     public function testCannotLoadEditPageForAnotherUsersReportTemplate()
     {
-        $this->markTestIncomplete('Returns 404...');
-
         $user = User::factory()->canViewReports()->create();
         $reportTemplate = ReportTemplate::factory()->create();