Merge pull request #16918 from marcusmoore/bug/sc-29151

Handle displaying deleted creator of an accessory

Author: snipe

resources/views/accessories/view.blade.php

@@ -324,7 +324,11 @@ class="table table-striped snipe-table"
                   </strong>
               </div>
               <div class="col-md-9" style="word-wrap: break-word;">
-                  {{ $accessory->adminuser?->present()->fullName() }}
+                  @if ($accessory->adminuser)
+                      {{ $accessory->adminuser->present()->fullName() }}
+                  @else
+                      {{ trans('admin/reports/general.deleted_user') }}
+                  @endif
               </div>
           </div>
 

tests/Feature/Accessories/Ui/ShowAccessoryTest.php

@@ -47,4 +47,13 @@ public function testPageRenders()
             ->assertOk();
 
     }
+
+    public function testHandlesAccessoryCreatorNotExisting()
+    {
+        $accessory = Accessory::factory()->create(['created_by' => 999999]);
+
+        $this->actingAs(User::factory()->superuser()->create())
+            ->get(route('accessories.show', $accessory))
+            ->assertOk();
+    }
 }