Skip to content

Commit df3e8ec

Browse files
committed
cleaning up notes
1 parent c0a99d6 commit df3e8ec

File tree

2 files changed

+0
-8
lines changed

2 files changed

+0
-8
lines changed

app/Http/Controllers/ReportsController.php

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -437,15 +437,8 @@ public function postCustom(CustomAssetReportRequest $request) : StreamedResponse
437437
$handle = fopen('php://output', 'w');
438438
stream_set_timeout($handle, 2000);
439439

440-
//this is handling emdash encoding, and is preventing that character from becoming something like —
441440
fprintf($handle, chr(0xEF).chr(0xBB).chr(0xBF));
442441

443-
//U+00EC is accent grave in model number
444-
//U+00EE is circumflex in model name
445-
//why is the same character a value of 2 off of each other?
446-
//why are we all getting different outputs for this emdash?
447-
//exporting and opening with a text editor doesn't fuck it up? so its NOT on export. It's an Excel problem.
448-
449442
$header = [];
450443

451444
if ($request->filled('id')) {

database/migrations/2013_11_13_075318_create_models_table.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ public function up()
1919
$table->integer('category_id')->nullable();
2020
$table->timestamps();
2121
$table->engine = 'InnoDB';
22-
//making a note here. Interestingly we state the model and modelno cloumns as strings. Tableplus stores as a var_string.
2322
});
2423
}
2524

0 commit comments

Comments
 (0)