Agenda for June 2 - 6, 2025 #17070
snipe
announced in
Weekly Reports
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Update: We're going to also (or perhaps instead of) try to stick to the public milestones. For this next sprint, you can see what's in there here: https://github.com/grokability/snipe-it/milestone/26
Possible regressions / change of expected behavior
We fixed what was previously a bug - the admin CC email was not being emailed if the checkout target was not something that could not be notified - location, another asset, etc. While the fixed way is more correct, I can certainly see how people might only want to get checkout notifications on things that require asset acceptance.
Bulk editing assets
Requestables
Datepickers
There are a hundred ways we've tried to solve this, and people complain about all of them. The way I think we should probably handle this is the same way we do for
start_date
in asset maintenances, where it does let you type in a date but it won't let you tab out or submit it with non-conforming text. The issue I have with that though is that if you blindly type something like "August 2, 2025", the date picker doesn't magically convert that into YYYY-MM-DD, and you could end up with a weird, irrelevant date without even realizing it before you hit send.There have been countless discussions about the HTML5 date picker, with tons of complaints about that solution as well, so that's not really even a solution (IMHO, tho my mind is willing to be changed.) The trickier part of any date-related stuff is that the date format changes regionally, and while PHP is pretty good at parsing dates, it has no way of knowing whether
11/10/12
is November 10, 2012, December 11, 2010, etc. It can parse dates, but it can't parse intent.Whatever way we solve it, it should at least be consistent throughout the system. I think a blade component would probably handle this nicely.
Active classes
Tasks
Git stuff:
We've seen varying incarnations of this over the years, and it's not actually something we're doing. It's usually caused by line-endings changing, or permission changes on the vendors directory, but I'd like to get some authoritative documentation on this so we don't have to deal with it again.
Features
Bulk deleting categories, etc:
This seems pretty reasonable (caveat caveat) but the way we do it right now in other places is gross, sort of a pseudo-controller middle-step that I'd love to not have. That said, we could add middle-controllers to these things as well and refactor once we have a "better" way.
Importer
We've already implemented this for the location importer, supplier importer and I think a few others, so it should work the same for assets.
In Testing:
Ongoing discussions:
Ongoing work:
Ongoing work describes tasks or features that take more time and touch a lot of different aspects of functionality and therefore come with more inherent risk of breaking things, this require even more extensive testing.
Replacing form helpers: Because of the choice that Laravel Collective has made to deprecate the HTML form helper (which Laravel themselves initially told us to use), @marcusmoore has been slowly and methodically replacing all of the
Form::
bits all throughout the system. This is obviously tedious work, but it will allow us to remove our own fork of the form helpers package down the line, with the added bonus of some nice blade components to work with for new forms.WIP: Fixed #9413 and rework upload API for bulk and better responses #16964 -
WIP for #16883 - bulk audit via API for RFID #16904 - once WIP: Fixed #9413 and rework upload API for bulk and better responses #16964 is done, we'll have finalized the response of the bulk-action responses in the API, so this should be easier to finish
Simpler logging refactor #16839 - relates to Not enough tests against Actionlogs during check-in and check-out (and possibly others) #17071
Investigate the newer Github issue form template options
Shorter-term goals
Longer-term goals
These are at least partially in progress, or being thought about actively to determine the best approach, but they are also very big, very difficult, and touch many things.
Beta Was this translation helpful? Give feedback.
All reactions