TimeZoneStruct wDayOfWeek and wDay were switched whan calculating DST start and end.

grammmichi · grammmichi · commit 78001390b05c · 2025-03-06T15:37:11.000+01:00
References: Issue #136
diff --git a/lib/grommunio/mapiprovider.php b/lib/grommunio/mapiprovider.php
@@ -2490,8 +2490,8 @@ private function isDST($localtime, $tz) {
 		}
 
 		$year = gmdate("Y", $localtime);
-		$start = $this->getTimestampOfWeek($year, $tz["dststartmonth"], $tz["dststartday"], $tz["dststartweek"], $tz["dststarthour"], $tz["dststartminute"], $tz["dststartsecond"]);
-		$end = $this->getTimestampOfWeek($year, $tz["dstendmonth"], $tz["dstendday"], $tz["dstendweek"], $tz["dstendhour"], $tz["dstendminute"], $tz["dstendsecond"]);
+		$start = $this->getTimestampOfWeek($year, $tz["dststartmonth"], $tz["dststartweek"], $tz["dststartday"], $tz["dststarthour"], $tz["dststartminute"], $tz["dststartsecond"]);
+		$end = $this->getTimestampOfWeek($year, $tz["dstendmonth"], $tz["dstendweek"], $tz["dstendday"], $tz["dstendhour"], $tz["dstendminute"], $tz["dstendsecond"]);
 
 		if ($start < $end) {
 			// northern hemisphere (july = dst)

Original file line number	Diff line number	Diff line change
`@@ -2490,8 +2490,8 @@ private function isDST($localtime, $tz) {`
`2490`	`2490`	`}`
`2491`	`2491`
`2492`	`2492`	`$year = gmdate("Y", $localtime);`
`2493`		`- $start = $this->getTimestampOfWeek($year, $tz["dststartmonth"], $tz["dststartday"], $tz["dststartweek"], $tz["dststarthour"], $tz["dststartminute"], $tz["dststartsecond"]);`
`2494`		`- $end = $this->getTimestampOfWeek($year, $tz["dstendmonth"], $tz["dstendday"], $tz["dstendweek"], $tz["dstendhour"], $tz["dstendminute"], $tz["dstendsecond"]);`
	`2493`	`+ $start = $this->getTimestampOfWeek($year, $tz["dststartmonth"], $tz["dststartweek"], $tz["dststartday"], $tz["dststarthour"], $tz["dststartminute"], $tz["dststartsecond"]);`
	`2494`	`+ $end = $this->getTimestampOfWeek($year, $tz["dstendmonth"], $tz["dstendweek"], $tz["dstendday"], $tz["dstendhour"], $tz["dstendminute"], $tz["dstendsecond"]);`
`2495`	`2495`
`2496`	`2496`	`if ($start < $end) {`
`2497`	`2497`	`// northern hemisphere (july = dst)`