Skip to content

debian packaging - wrong install paths #21

@crpb

Description

@crpb

Hey @grantma,

had this in a ticket but forgot about it and just got asked if it's still happening or if they could close it.

I will just copy/paste as my comments in german are not saying much anyhow and the rest speaks for itself1.

cheers,
Christopher


Da dpkg -V grommunio-sync meckert...

Problem:

root@grom-deb:~# apt-get remove grommunio-sync
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following packages were automatically installed and are no longer required:
  php-intl php8.2-intl
Use 'apt autoremove' to remove them.
The following packages will be REMOVED:
  grommunio-sync
0 upgraded, 0 newly installed, 1 to remove and 0 not upgraded.
After this operation, 1,537 kB disk space will be freed.
Do you want to continue? [Y/n]
(Reading database ... 40905 files and directories currently installed.)
Removing grommunio-sync (2.1.6.22f2119-0) ...
root@grom-deb:~# apt-get install grommunio-sync
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following NEW packages will be installed:
  grommunio-sync
0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
Need to get 0 B/242 kB of archives.
After this operation, 1,537 kB of additional disk space will be used.
Selecting previously unselected package grommunio-sync.
(Reading database ... 40741 files and directories currently installed.)
Preparing to unpack .../grommunio-sync_2.1.6.22f2119-0_all.deb ...
Unpacking grommunio-sync (2.1.6.22f2119-0) ...
Setting up grommunio-sync (2.1.6.22f2119-0) ...
'/usr/share/grommunio-sync/config.php' -> '/etc/grommunio-sync/grommunio-sync.conf.php'
'/usr/sbin/grommunio-sync-top' -> '/usr/share/grommunio-sync/grommunio-sync-top.php'
root@grom-deb:~# dpkg -V grommunio-sync
?M5??????   /usr/sbin/grommunio-sync-top

Fix:

From 0cbd22d9affd79b657c6163cd06a9b8622943a3b Mon Sep 17 00:00:00 2001
From: Christopher Bock <[email protected]>
Date: Tue, 11 Mar 2025 16:10:29 +0100
Subject: [PATCH] debhelper..

---
 debian/grommunio-sync.install  | 22 ++++++++++------------
 debian/grommunio-sync.links    |  3 +++
 debian/grommunio-sync.postinst |  3 ---
 debian/rules                   |  8 ++++----
 4 files changed, 17 insertions(+), 19 deletions(-)
 create mode 100644 debian/grommunio-sync.links

diff --git a/debian/grommunio-sync.install b/debian/grommunio-sync.install
index 86c372f..9b4f6a7 100644
--- a/debian/grommunio-sync.install
+++ b/debian/grommunio-sync.install
@@ -1,12 +1,10 @@
-grommunio-sync.conf.php             /etc/grommunio-sync/
-index.php                           /usr/share/grommunio-sync/
-lib                                 /usr/share/grommunio-sync/
-vendor                              /usr/share/grommunio-sync/
-version.php                         /usr/share/grommunio-sync/
-grommunio-sync-top                  /usr/sbin/
-grommunio-sync-top                  /usr/share/grommunio-sync/
-grommunio-sync-top.php              /usr/share/grommunio-sync/
-
-build/grommunio-sync.lr             etc/logrotate.d/
-
-build/grommunio-sync.conf           /usr/share/grommunio-common/nginx/locations.d/
+grommunio-sync.conf.php        etc/grommunio-sync
+index.php            usr/share/grommunio-sync
+lib                usr/share/grommunio-sync
+vendor                usr/share/grommunio-sync
+version.php            usr/share/grommunio-sync
+grommunio-sync-top        usr/share/grommunio-sync
+grommunio-sync-top.php        usr/share/grommunio-sync
+build/grommunio-sync.lr        etc/logrotate.d
+build/grommunio-sync.conf    usr/share/grommunio-common/nginx/locations.d
+build/sysuser.conf         usr/lib/sysusers.d
diff --git a/debian/grommunio-sync.links b/debian/grommunio-sync.links
new file mode 100644
index 0000000..1fa84ec
--- /dev/null
+++ b/debian/grommunio-sync.links
@@ -0,0 +1,3 @@
+etc/grommunio-sync/grommunio-sync.conf.php usr/share/grommunio-sync/config.php
+usr/share/grommunio-sync/grommunio-sync-top.php usr/sbin/grommunio-sync-top
+
diff --git a/debian/grommunio-sync.postinst b/debian/grommunio-sync.postinst
index 4eeb3fd..01cedcd 100644
--- a/debian/grommunio-sync.postinst
+++ b/debian/grommunio-sync.postinst
@@ -33,9 +33,6 @@ case "$1" in
         set_perms root grosync 0770 /etc/grommunio-sync
         set_perms grosync grosync 0770 /var/log/grommunio-sync
 
-    ln -sfv "/etc/grommunio-sync/grommunio-sync.conf.php" "/usr/share/grommunio-sync/config.php"
-    ln -sfv "/usr/share/grommunio-sync/grommunio-sync-top.php" "/usr/sbin/grommunio-sync-top"
-
     systemctl list-units --plain --no-legend --quiet "php*fpm.service" | \
     awk '{print$1}' | xargs /usr/bin/systemctl try-restart
         if [ -f /usr/share/grommunio-common/nginx/locations.d/grommunio-sync.conf ]; then
diff --git a/debian/rules b/debian/rules
index 251e2e0..4f313d2 100755
--- a/debian/rules
+++ b/debian/rules
@@ -21,8 +21,9 @@ override_dh_auto_install:
     sed -s "s/__VERSION__/${DEB_VERSION}/" build/version.php.in > version.php
     mkdir -p ${INSTDIR}/usr/share/grommunio-sync
 
-    mv "config.php" "grommunio-sync.conf.php"
-    
+    # Rename Config
+    mv -v config.php grommunio-sync.conf.php
+
     # Nginx conf
     mkdir -pv "${INSTDIR}/usr/share/grommunio-common/nginx/locations.d"
     install -Dpvm 644 build/grommunio-sync.conf "${INSTDIR}/usr/share/grommunio-common/nginx/locations.d/"
@@ -31,10 +32,9 @@ override_dh_auto_install:
     install -Dpvm 644 build/grommunio-sync-upstream.conf "${INSTDIR}/usr/share/grommunio-common/nginx/upstreams.d/grommunio-sync.conf"
 
     # PHP-FPM
-    mkdir -pv "${INSTDIR}/${phpdir}/fpm/pool.d" "${INSTDIR}/usr/lib/sysusers.d"
+    mkdir -pv "${INSTDIR}/${phpdir}/fpm/pool.d"
     sed -i "s#/run/php-fpm/#/run/php/#g" build/pool-grommunio-sync.conf
     install -Dpvm 644 build/pool-grommunio-sync.conf "${INSTDIR}/${phpdir}/fpm/pool.d/"
-    cp -a build/sysuser.conf "${INSTDIR}/usr/lib/sysusers.d/grommunio-sync.conf"
 
     dh_install
     mkdir -p ${INSTDIR}/var/log/grommunio-sync
-- 
2.47.2

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions