Skip to content

Commit 061aefa

Browse files
committed
exmdb, emsmdb: enable softdelete by default
Historically, Gromox could only do harddeletes in private stores. Since about gromox-2.0-76-g9c860fca2, private stores are able to record such a "softdelete" flag. The default configuration was still set to exmdb_private_folder_softdelete=0, i.e. all requests for object soft deletion would be treated as hard deletions. Except: that did not consistently happen, and private stores could amass softdel messages even if disabled by the admin. The situation only changed with gromox-2.48-120-gcc78fbdfa where this defect was closed; since then, exmdb_private_folder_softdelete=0 meant harddeletes. In other words, softdel was exercised by the userbase already (even if by accident) and since cc78fbd, that seemed to no longer work. Change the default config setting for softdeletions for real now. (This influences a future development, which now has to consider the presence of Gromox-2.0-style softdel messages. That's all.) References: GXL-362
1 parent d5eef7c commit 061aefa

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

doc/exchange_emsmdb.4gx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ Enables soft-delete support for folders in private stores. (This feature is
9090
experimental.) Public folders always have this on. (Take note that
9191
exmdb_provider.cfg:exmdb_private_folder_softdelete also need to be enabled.)
9292
.br
93-
Default: \fIno\fP
93+
Default: \fIyes\fP
9494
.TP
9595
\fBemsmdb_rop_chaining\fP
9696
0: Deactivate ROP chaining. 1: Enable ROP chaining for OL < 15 and OL >=

doc/exmdb_provider.4gx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ Default: \fI2\fP
110110
Enables soft-delete support for folders in private stores. (This feature is
111111
experimental.) Public folders always have this on.
112112
.br
113-
Default: \fIno\fP
113+
Default: \fIyes\fP
114114
.TP
115115
\fBexmdb_schema_upgrades\fP
116116
This directive controls whether database schemas are automatically upgraded

exch/emsmdb/main.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ static constexpr cfg_directive emsmdb_cfg_defaults[] = {
5858
{"ems_max_pending_sesnotif", "1K", CFG_SIZE, "0"},
5959
{"emsmdb_max_cxh_per_user", "100", CFG_SIZE, "100"},
6060
{"emsmdb_max_obh_per_session", "500", CFG_SIZE, "500"},
61-
{"emsmdb_private_folder_softdelete", "0", CFG_BOOL},
61+
{"emsmdb_private_folder_softdelete", "1", CFG_BOOL},
6262
{"emsmdb_rop_chaining", "1"},
6363
{"mailbox_ping_interval", "5min", CFG_TIME, "60s", "1h"},
6464
{"max_ext_rule_length", "510K", CFG_SIZE, "1"},

exch/exmdb/main.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ static constexpr cfg_directive exmdb_cfg_defaults[] = {
5454
{"exmdb_max_sqlite_spares", "3", CFG_SIZE},
5555
{"exmdb_pf_read_per_user", "1"},
5656
{"exmdb_pf_read_states", "2"},
57-
{"exmdb_private_folder_softdelete", "0", CFG_BOOL},
57+
{"exmdb_private_folder_softdelete", "1", CFG_BOOL},
5858
{"exmdb_schema_upgrades", "auto"},
5959
{"exmdb_search_nice", "0"},
6060
{"exmdb_search_pacing", "250", CFG_SIZE},

0 commit comments

Comments
 (0)