imap: case insensitivity for folders

MAPI folders are already case-insensitive, so apply the same behavior
for midb/imapd. With the bad encoding decisions weeded out, this
should be easy... now.

Fixes: gromox-0~666
References: DESK-2409

Author: jengelh

exch/midb/mail_engine.cpp

@@ -182,7 +182,7 @@ template<typename T> static inline bool
 array_find_str(const T &kwlist, const char *s)
 {
 	for (const auto kw : kwlist)
-		if (strcmp(s, kw) == 0)
+		if (strcasecmp(s, kw) == 0)
 			return true;
 	return false;
 }
@@ -337,13 +337,13 @@ static std::unique_ptr<char[]> mail_engine_ct_decode_mime(const char *charset,
 				end_pos - begin_pos + 1, &encode_string);
 			auto tmp_len = strlen(encode_string.title);
 			std::unique_ptr<char[]> tmp_string;
-			if (0 == strcmp(encode_string.encoding, "base64")) {
+			if (strcasecmp(encode_string.encoding, "base64") == 0) {
 				size_t decode_len = 0;
 				decode64(encode_string.title, tmp_len,
 				         temp_buff, std::size(temp_buff), &decode_len);
 				temp_buff[decode_len] = '\0';
 				tmp_string = mail_engine_ct_to_utf8(encode_string.charset, temp_buff);
-			} else if (0 == strcmp(encode_string.encoding, "quoted-printable")){
+			} else if (strcasecmp(encode_string.encoding, "quoted-printable") == 0) {
 				auto decode_len = qp_decode_ex(temp_buff, std::size(temp_buff),
 				                  encode_string.title, tmp_len);
 				if (decode_len < 0)
@@ -1332,7 +1332,7 @@ static std::optional<std::vector<int>> mail_engine_ct_match(const char *charset,
 static uint64_t me_get_folder_id_raw(IDB_ITEM *pidb, std::string_view name)
 {
 	auto pstmt = gx_sql_prep(pidb->psqlite, "SELECT "
-	             "folder_id FROM folders WHERE name=?");
+	             "folder_id FROM folders WHERE name=? COLLATE NOCASE LIMIT 1");
 	if (pstmt == nullptr)
 		return 0;
 	pstmt.bind_text(1, name);
@@ -1858,7 +1858,7 @@ static BOOL mail_engine_sync_mailbox(IDB_ITEM *pidb,
 					parent_fid, folder_id);
 				gx_sql_exec(pidb->psqlite, qstr.c_str());
 			}
-			if (strcmp(encoded_name.c_str(), pstmt1.col_text(3)) != 0) {
+			if (strcasecmp(encoded_name.c_str(), pstmt1.col_text(3)) != 0) {
 				auto ust = gx_sql_prep(pidb->psqlite, "UPDATE folders SET name=? "
 				           "WHERE folder_id=?");
 				if (ust == nullptr ||
@@ -2455,7 +2455,7 @@ static int mail_engine_mrenf(int argc, char **argv, int sockd)
 	if (!system_services_get_user_ids(pidb->username.c_str(), &user_id, nullptr, nullptr))
 		return MIDB_E_SSGETID;
 	auto pstmt = gx_sql_prep(pidb->psqlite, "SELECT folder_id,"
-	             " parent_fid FROM folders WHERE name=?");
+	             " parent_fid FROM folders WHERE name=? COLLATE NOCASE");
 	if (pstmt == nullptr)
 		return MIDB_E_SQLPREP;
 	pstmt.bind_text(1, decoded_name);

lib/dbop_sqlite.cpp

@@ -497,6 +497,20 @@ static constexpr char tbl_midb_folders_0[] =
 "  sort_field INTEGER DEFAULT 0);"
 "CREATE INDEX parent_fid_index ON folders(parent_fid);";
 
+static constexpr char tbl_midb_folders_2[] =
+"CREATE TABLE folders ("
+"  folder_id INTEGER PRIMARY KEY,"
+"  parent_fid INTEGER NOT NULL,"
+"  commit_max INTEGER NOT NULL,"
+"  name TEXT NOT NULL COLLATE NOCASE UNIQUE,"
+"  uidnext INTEGER DEFAULT 0,"
+"  unsub INTEGER DEFAULT 0,"
+"  sort_field INTEGER DEFAULT 0);"
+"CREATE INDEX parent_fid_index2 ON folders(parent_fid);";
+
+static constexpr char tbl_midb_folders_move2[] =
+"INSERT INTO folders SELECT folder_id, parent_fid, commit_max, name, uidnext, unsub, sort_field FROM u0";
+
 static constexpr char tbl_midb_msgs_0[] =
 "CREATE TABLE messages ("
 "  message_id INTEGER PRIMARY KEY,"
@@ -550,7 +564,7 @@ static constexpr tbl_init tbl_midb_init_0[] = {
 
 static constexpr tbl_init tbl_midb_init_top[] = {
 	{"configurations", tbl_config_1},
-	{"folders", tbl_midb_folders_0},
+	{"folders", tbl_midb_folders_2},
 	{"messages", tbl_midb_msgs_0},
 	{"mapping", tbl_midb_mapping_0},
 	TABLE_END,
@@ -602,6 +616,7 @@ static constexpr tblite_upgradefn tbl_pub_upgrade_list[] = {
 
 static constexpr tblite_upgradefn tbl_midb_upgrade_list[] = {
 	{1, nullptr, "configurations", tbl_config_1, tbl_config_move1},
+	{2, nullptr, "folders", tbl_midb_folders_2, tbl_midb_folders_move2},
 	TABLE_END,
 };
 

mra/imap/imap_cmd_parser.cpp

@@ -129,7 +129,7 @@ void dir_tree::load_from_memfile(const std::vector<enum_folder_t> &pfile) try
 			if (NULL != pnode) {
 				do {
 					auto pdir = static_cast<DIR_NODE *>(pnode->pdata);
-					if (strcmp(pdir->name, ptr1) == 0)
+					if (strcasecmp(pdir->name, ptr1) == 0)
 						break;
 				} while ((pnode = pnode->get_sibling()) != nullptr);
 			}
@@ -187,9 +187,9 @@ DIR_NODE *dir_tree::match(const char *path)
 			return NULL;
 		do {
 			pdir = static_cast<DIR_NODE *>(pnode->pdata);
-			if (strcmp(pdir->name, ptr1) == 0)
+			if (strcasecmp(pdir->name, ptr1) == 0)
 				break;
-			if (level == 0 && strcmp(pdir->name, "INBOX") == 0 &&
+			if (level == 0 && strcasecmp(pdir->name, "INBOX") == 0 &&
 			    strcasecmp(ptr1, "inbox") == 0)
 				break;
 		} while ((pnode = pnode->get_sibling()) != nullptr);
@@ -1618,15 +1618,15 @@ int imap_cmd_parser_create(int argc, char **argv, imap_context *pcontext)
 	if (sys_name.size() > 0 && sys_name.back() == '/')
 		sys_name.pop_back();
 	if (std::any_of(folder_list.cbegin(), folder_list.cend(),
-	    [&](const enum_folder_t &e) { return strcmp(e.second.c_str(), sys_name.c_str()) == 0; }))
+	    [&](const enum_folder_t &e) { return strcasecmp(e.second.c_str(), sys_name.c_str()) == 0; }))
 		return 1926;
 	auto len = sys_name.size();
 	for (size_t i = 0; i <= len; ++i) {
 		if (sys_name[i] != '/' && sys_name[i] != '\0')
 			continue;
 		sys_name[i] = '\0';
 		if (std::any_of(folder_list.cbegin(), folder_list.cend(),
-		    [&](const enum_folder_t &e) { return strcmp(e.second.c_str(), sys_name.c_str()) == 0; })) {
+		    [&](const enum_folder_t &e) { return strcasecmp(e.second.c_str(), sys_name.c_str()) == 0; })) {
 			sys_name[i] = '/';
 			continue;
 		}