zcore: fix use-after-free on shutdown

rpc_parser needs to be ordered after service(mysql_adaptor),
otherwise on shutdown, the mysql objects are gone while rpc_parser
still uses them.

Author: jengelh

exch/zcore/main.cpp

@@ -405,13 +405,6 @@ int main(int argc, char **argv)
 	int ping_interval = pconfig->get_ll("mailbox_ping_interval");
 	HX_unit_seconds(temp_buff, std::size(temp_buff), ping_interval, 0);
 	mlog(LV_INFO, "system: mailbox ping interval is %s", temp_buff);
-	
-	zserver_init(table_size, cache_interval, ping_interval);
-	auto cl_7 = make_scope_exit(zserver_stop);
-	exmdb_client_init(proxy_num, stub_num);
-	auto cl_8 = make_scope_exit(exmdb_client_stop);
-	rpc_parser_init(threads_num);
-	auto cl_6 = make_scope_exit(rpc_parser_stop);
 
 	if (service_run_early() != 0) {
 		mlog(LV_ERR, "system: failed to run PLUGIN_EARLY_INIT");
@@ -431,6 +424,15 @@ int main(int argc, char **argv)
 		mlog(LV_ERR, "system: failed to start system services");
 		return EXIT_FAILURE;
 	}
+
+	zserver_init(table_size, cache_interval, ping_interval);
+	auto cl_7 = make_scope_exit(zserver_stop);
+	exmdb_client_init(proxy_num, stub_num);
+	auto cl_8 = make_scope_exit(exmdb_client_stop);
+	/* parser after zserver: dependency on session table */
+	/* parser after service: dependency on mysql_adaptor */
+	rpc_parser_init(threads_num);
+	auto cl_6 = make_scope_exit(rpc_parser_stop);
 	listener_init();
 	auto cl_10 = make_scope_exit(listener_stop);
 	if (listener_run(g_config_file->get_value("zcore_listen")) != 0) {