nsp: split some code out into NSPROW::has_properror

Author: jengelh

exch/mh/nsp_common.cpp

@@ -286,12 +286,8 @@ static BOOL cu_nsp_proprow_to_proprow(const LPROPTAG_ARRAY &cols,
 		if (abrow.pppropval == nullptr)
 			return false;
 	}
-	size_t i;
-	for (i = 0; i < nsprow.cvalues; ++i)
-		if (PROP_TYPE(nsprow.pprops[i].proptag) == PT_ERROR)
-			break;
-	abrow.flag = i < nsprow.cvalues ? PROPERTY_ROW_FLAG_FLAGGED : PROPERTY_ROW_FLAG_NONE;
-	for (i = 0; i < nsprow.cvalues; ++i) {
+	abrow.flag = nsprow.has_properror() ? PROPERTY_ROW_FLAG_FLAGGED : PROPERTY_ROW_FLAG_NONE;
+	for (size_t i = 0; i < nsprow.cvalues; ++i) {
 		auto &nsprop = nsprow.pprops[i];
 		if (PROP_TYPE(nsprop.proptag) == PT_ERROR) {
 			auto ap = cu_alloc<FLAGGED_PROPVAL>();

exch/nsp/nsp_interface.cpp

@@ -1686,13 +1686,8 @@ ec_error_t nsp_interface_get_props(NSPI_HANDLE handle, uint32_t flags,
 			count++;
 		}
 		rowset->cvalues = count;
-	} else {
-		for (size_t i = 0; i < rowset->cvalues; ++i) {
-			if (PROP_TYPE(rowset->pprops[i].proptag) == PT_ERROR) {
-				result = ecWarnWithErrors;
-				break;
-			}
-		}
+	} else if (rowset->has_properror()) {
+		result = ecWarnWithErrors;
 	}
 	if (result == ecSuccess || result == ecWarnWithErrors)
 		*pprows = rowset;

exch/nsp/nsp_types.hpp

@@ -83,6 +83,12 @@ struct NSP_PROPROW {
 		auto v = find(tag);
 		return v != nullptr ? &v->value : nullptr;
 	}
+	bool has_properror() const {
+		for (size_t i = 0; i < cvalues; ++i)
+			if (PROP_TYPE(pprops[i].proptag) == PT_ERROR)
+				return true;
+		return false;
+	}
 
 	uint32_t reserved;
 	uint32_t cvalues;