Skip to content

Commit 42ad3e6

Browse files
committed
midb: fix wrong allocate_message_id call in mcopy routine
There is no immediate ill effect in obtaining a message id from the wrong folder, but doing so contributes to fragmentation of the MID space, which reduces the efficacy of packed (serialized) idsets. Fixes: gromox-0~666
1 parent 6a26816 commit 42ad3e6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

exch/midb/mail_engine.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2495,7 +2495,7 @@ static int mail_engine_mcopy(int argc, char **argv, int sockd) try
24952495
return MIDB_E_NO_MEMORY;
24962496
}
24972497
if (!exmdb_client::allocate_message_id(argv[1],
2498-
rop_util_make_eid_ex(1, src_fid), &message_id) ||
2498+
rop_util_make_eid_ex(1, dst_fid), &message_id) ||
24992499
!exmdb_client::allocate_cn(argv[1], &change_num))
25002500
return MIDB_E_MDB_ALLOCID;
25012501

0 commit comments

Comments
 (0)