exmdb: remodel exmdb_server::deliver_message's way of vivified mails

The deliver_message handler would only add message_id into the notify
set if the DELIVERY_DO_RULES flag was given. However, when
lda_twostep_processor is used, the DO_RULES flag for server-side rule
processing is not set, since the client is supposed to take care of
everything, new mail notification included.

Now, in a twist, clients are not so much listening for events of type
fnevNewMail, but rather fnevObjectCreated on content tables.

When TWOSTEP was enabled, exmdb_server::deliver_message would not
emit fnevObjectCreated, but lib/ruleproc.cpp would immediately call
exmdb_server::notify_new_mail, which did emit fnevObjectCreated. In
9152bab, lib/ruleproc.cpp was changed from notify_new_mail to
transport_new_mail, so deliver_message should have received a change
to send fnevObjectCreated, but that did not happen.

Fixes: gromox-2.46-89-g9152babd7
References: GXH-154, GXL-616, DESK-3712, DESK-3715, DESK-3716

Author: jengelh

doc/changelog.rst

@@ -1,3 +1,12 @@
+Development 2.48.5
+==================
+
+Fixes:
+
+* fnevObjectCreate notifications were not sent when a mail was processed
+  through TWOSTEP Rule Processor, now fixed
+
+
 Gromox 2.48 (2025-07-31)
 ========================
 

exch/exmdb/message.cpp

@@ -70,6 +70,8 @@ struct DAM_NODE {
 
 struct message_node {
 	uint64_t folder_id = 0, message_id = 0;
+
+	auto operator<=>(const message_node &) const = default;
 };
 
 struct rulexec_in {
@@ -3563,8 +3565,8 @@ static ec_error_t message_rule_new_message(const rulexec_in &rp, seen_list &seen
 	}
 	if (dam_list.size() > 0 && !message_make_dams(rp, std::move(dam_list), seen))
 		return ecError;
-	if (!b_del) try {
-		seen.msg.emplace_back(message_node{rp.folder_id, rp.message_id});
+	if (b_del) try {
+		std::erase(seen.msg, message_node{rp.folder_id, rp.message_id});
 		return ecSuccess;
 	} catch (const std::bad_alloc &) {
 		mlog(LV_ERR, "E-2029: ENOMEM");
@@ -3777,6 +3779,8 @@ BOOL exmdb_server::deliver_message(const char *dir, const char *from_address,
 	mlog(LV_DEBUG, "to=%s from=%s fid=%llu delivery mid=%llu (%s)", account.c_str(),
 		znul(from_address), LLU{fid_val}, LLU{message_id},
 		partial ? " (partial only)" : "");
+
+	seen.msg.emplace_back(fid_val, message_id);
 	if (dlflags & DELIVERY_DO_RULES) {
 		auto ec = message_rule_new_message({from_address, account.c_str(), cpid, b_oof,
 		          pdb->psqlite, fid_val, message_id, std::move(digest)}, seen);