oxcical: fix wrong BYMONTH calculation for ical-exported MONTHNTH recurrences

jengelh · jengelh · commit 686e92dcb389 · 2025-06-12T17:30:19.000+02:00
There appears to be a missing call to `ical_get_itime_from_yearday`.
The RRULE line for a yearly recurrence "every 1st Sunday in May"
produced:

RRULE:FREQ=YEARLY;INTERVAL=1;BYDAY=SU;BYSETPOS=1;BYMONTH=172800

Fixes: gromox-0~666
References: GXH-149
diff --git a/lib/mapi/oxcical.cpp b/lib/mapi/oxcical.cpp
@@ -2978,7 +2978,8 @@ static bool oxcical_export_rrule(const ical_component *ptz_component,
 				piline->append_value("BYSETPOS", "-1");
 			else
 				piline->append_value("BYSETPOS", std::to_string(apr->recur_pat.pts.monthnth.recurnum));
-			piline->append_value("BYMONTH", std::to_string(apr->recur_pat.firstdatetime));
+			ical_get_itime_from_yearday(1601, apr->recur_pat.firstdatetime / 1440 + 1, &itime);
+			piline->append_value("BYMONTH", std::to_string(itime.month));
 		}
 		break;
 	}

Original file line number	Diff line number	Diff line change
`@@ -2978,7 +2978,8 @@ static bool oxcical_export_rrule(const ical_component *ptz_component,`
`2978`	`2978`	`piline->append_value("BYSETPOS", "-1");`
`2979`	`2979`	`else`
`2980`	`2980`	`piline->append_value("BYSETPOS", std::to_string(apr->recur_pat.pts.monthnth.recurnum));`
`2981`		`- piline->append_value("BYMONTH", std::to_string(apr->recur_pat.firstdatetime));`
	`2981`	`+ ical_get_itime_from_yearday(1601, apr->recur_pat.firstdatetime / 1440 + 1, &itime);`
	`2982`	`+ piline->append_value("BYMONTH", std::to_string(itime.month));`
`2982`	`2983`	`}`
`2983`	`2984`	`break;`
`2984`	`2985`	`}`