http: resolve cov-scan warning COPY_INSTEAD_OF_MOVE

Sergey Komarov · jengelh · commit bec6abaa19b7 · 2025-03-30T00:31:57.000+01:00
CID 1590459: (#1 of 1): Variable copied when it could be moved (COPY_INSTEAD_OF_MOVE) copy_constructor_call: node is copied and then passed-by-reference as parameter to STL insertion function std::vector<FASTCGI_NODE, std::allocator<FASTCGI_NODE> >::push_back(std::vector<FASTCGI_NODE, std::allocator<FASTCGI_NODE> >::value_type const &), when it could be moved instead Fixes: gromox-2.29-2-gdb53d5689
diff --git a/exch/http/fastcgi.cpp b/exch/http/fastcgi.cpp
@@ -165,7 +165,7 @@ static int mod_fastcgi_defaults()
 	node.path = "/dav";
 	node.dir = DATADIR "/grommunio-dav";
 	node.sock_path = FPMSOCKDIR "/php-grommunio-dav-fpm.sock";
-	g_fastcgi_list.push_back(node);
+	g_fastcgi_list.push_back(std::move(node));
 	return 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -165,7 +165,7 @@ static int mod_fastcgi_defaults()`
`165`	`165`	`node.path = "/dav";`
`166`	`166`	`node.dir = DATADIR "/grommunio-dav";`
`167`	`167`	`node.sock_path = FPMSOCKDIR "/php-grommunio-dav-fpm.sock";`
`168`		`- g_fastcgi_list.push_back(node);`
	`168`	`+ g_fastcgi_list.push_back(std::move(node));`
`169`	`169`	`return 0;`
`170`	`170`	`}`
`171`	`171`