build: resolve build failures under -DCOMPILE_DIAG

```
rtf.cpp: In member function 'push_da_pic':
rtf.cpp:2604:37: error: use of deleted function 'ec_error_t::operator bool()'
 2604 | if ((ret = atx->proplist.set(PR_ATTACH_MIME_TAG, img_ctype)) != ecSuccess ||
```

Fixes: gromox-2.44-102-g0e07767b8

Author: jengelh

exch/zcore/ics_state.cpp

@@ -90,7 +90,7 @@ BINARY *ics_state::serialize()
 
 	if (ICS_TYPE_CONTENTS == pstate->type) {
 		decltype(ser) s(pstate->pseen_fai->serialize());
-		if (s == nullptr || pproplist->set(MetaTagCnsetSeenFAI, s.get()) != 0)
+		if (s == nullptr || pproplist->set(MetaTagCnsetSeenFAI, s.get()) != ecSuccess)
 			return NULL;
 	}
 

lib/mapi/rtf.cpp

@@ -256,7 +256,7 @@ struct rtf_reader final {
 	bool build_font_table(SIMPLE_TREE_NODE *);
 	bool escape_output(char *);
 	bool word_output_date(SIMPLE_TREE_NODE *);
-	errno_t push_da_pic(EXT_PUSH &, const char *, const char *, const char *, const char *);
+	int push_da_pic(EXT_PUSH &, const char *, const char *, const char *, const char *);
 
 	CMD_PROC_FN cmd_ansi, cmd_ansicpg, cmd_b, cmd_bullet, cmd_caps, cmd_cb,
 	cmd_cf, cmd_colortbl, cmd_continue, cmd_deff, cmd_dn, cmd_emboss,
@@ -2580,7 +2580,7 @@ static CMD_PROC_FUNC rtf_find_fromhtml_func(const char *s)
 	return nullptr;
 }
 
-errno_t rtf_reader::push_da_pic(EXT_PUSH &picture_push, const char *img_ctype,
+int rtf_reader::push_da_pic(EXT_PUSH &picture_push, const char *img_ctype,
     const char *pext, const char *cid_name, const char *picture_name)
 {
 	auto reader = this;
@@ -2592,14 +2592,14 @@ errno_t rtf_reader::push_da_pic(EXT_PUSH &picture_push, const char *img_ctype,
 	    picture_push.p_uint8(0) != EXT_ERR_SUCCESS ||
 	    !decode_hex_binary(picture_push.m_cdata, bin.pv, bin.cb)) {
 		free(bin.pv);
-		return EINVAL;
+		return -EINVAL;
 	}
 	auto atx = attachment_content_init();
 	if (atx == nullptr || !reader->pattachments->append_internal(atx)) {
 		free(bin.pv);
-		return EINVAL;
+		return -EINVAL;
 	}
-	int ret;
+	ec_error_t ret;
 	uint32_t flags = ATT_MHTML_REF;
 	if ((ret = atx->proplist.set(PR_ATTACH_MIME_TAG, img_ctype)) != ecSuccess ||
 	    (ret = atx->proplist.set(PR_ATTACH_CONTENT_ID, cid_name)) != ecSuccess ||
@@ -2608,13 +2608,13 @@ errno_t rtf_reader::push_da_pic(EXT_PUSH &picture_push, const char *img_ctype,
 	    (ret = atx->proplist.set(PR_ATTACH_FLAGS, &flags)) != ecSuccess ||
 	    (ret = atx->proplist.set(PR_ATTACH_DATA_BIN, &bin)) != ecSuccess) {
 		free(bin.pv);
-		return ret;
+		return ece2nerrno(ret);
 	}
 	free(bin.pv);
 	if (reader->ext_push.p_bytes(TAG_IMAGELINK_BEGIN, sizeof(TAG_IMAGELINK_BEGIN) - 1) != EXT_ERR_SUCCESS ||
 	    reader->ext_push.p_bytes(cid_name, strlen(cid_name)) != EXT_ERR_SUCCESS ||
 	    reader->ext_push.p_bytes(TAG_IMAGELINK_END, sizeof(TAG_IMAGELINK_END) - 1) != EXT_ERR_SUCCESS)
-		return EINVAL;
+		return -EINVAL;
 	return 0;
 }
 

tools/genimport.cpp

@@ -224,12 +224,12 @@ int exm_set_change_keys(TPROPVAL_ARRAY *props, eid_t change_num)
 		fprintf(stderr, "exm: pcl_serialize: ENOMEM\n");
 		return -ENOMEM;
 	}
-	int ret;
+	ec_error_t ret;
 	if ((ret = props->set(PidTagChangeNumber, &change_num)) != ecSuccess ||
 	    (ret = props->set(PR_CHANGE_KEY, &bxid)) != ecSuccess ||
 	    (ret = props->set(PR_PREDECESSOR_CHANGE_LIST, pclbin.get())) != ecSuccess) {
-		fprintf(stderr, "%s: %s\n", __func__, strerror(-ret));
-		return ret;
+		fprintf(stderr, "%s: %s\n", __func__, mapi_strerror(ret));
+		return ece2nerrno(ret);
 	}
 	return 0;
 }
@@ -403,7 +403,7 @@ int exm_create_msg(uint64_t parent_fld, MESSAGE_CONTENT *ctnt)
 	    (ret = props->set(PidTagChangeNumber, &change_num)) != ecSuccess ||
 	    (ret = props->set(PR_CHANGE_KEY, &bxid)) != ecSuccess ||
 	    (ret = props->set(PR_PREDECESSOR_CHANGE_LIST, pclbin.get())) != ecSuccess) {
-		fprintf(stderr, "exm: tpropval: %s\n", strerror(-ret));
+		fprintf(stderr, "exm: tpropval: %s\n", mapi_strerror(ret));
 		return ece2nerrno(ret);
 	}
 	if (!exmdb_client->write_message(g_storedir, CP_UTF8, parent_fld, ctnt, &ret)) {