ruleproc: auto-enter MRs into target calender even sender won't get response

The FB readout permissions for the sender must not apply to the
autoprocessor itself. MRs should be entered into the target calendar
even if the sender does not have rights to elicit insight into the
schedule.

References: GXL-602, DESK-3257, DESK-3790, DESK-3821

Author: jengelh

include/gromox/freebusy.hpp

@@ -8,4 +8,5 @@
 
 using namespace gromox;
 
+extern GX_EXPORT unsigned int freebusy_perms(const char *actor, const char *target);
 extern GX_EXPORT bool get_freebusy(const char *, const char *, time_t, time_t, std::vector<freebusy_event> &);

lib/freebusy.cpp

@@ -325,16 +325,24 @@ static bool goid_to_icaluid(BINARY *gobj, std::string &uid_buf)
 	return true;
 }
 
+unsigned int freebusy_perms(const char *actor, const char *target)
+{
+	auto cal_eid = rop_util_make_eid_ex(1, PRIVATE_FID_CALENDAR);
+	uint32_t perm = 0;
+	if (!exmdb_client->get_folder_perm(target, cal_eid, actor, &perm))
+		return 0;
+	return perm & (frightsFreeBusySimple | frightsFreeBusyDetailed | frightsReadAny);
+}
+
 bool get_freebusy(const char *username, const char *dir, time_t start_time,
     time_t end_time, std::vector<freebusy_event> &fb_data)
 {
 	uint32_t permission = 0;
 	auto cal_eid = rop_util_make_eid_ex(1, PRIVATE_FID_CALENDAR);
 
 	if (username != nullptr) {
-		if (!exmdb_client->get_folder_perm(dir, cal_eid, username, &permission))
-			return false;
-		if (!(permission & (frightsFreeBusySimple | frightsFreeBusyDetailed | frightsReadAny)))
+		permission = freebusy_perms(username, dir);
+		if (permission == 0)
 			return false;
 	} else {
 		permission = frightsFreeBusyDetailed | frightsReadAny;

lib/ruleproc.cpp

@@ -1174,15 +1174,16 @@ static ec_error_t mr_do_request(rxparam &par, const PROPID_ARRAY &propids,
 	}
 
 	/* Lookup conflict state */
-	bool res_in_use = false;
+	bool res_in_use = false, response_allowed = false;
 	auto start_nt = rq_prop.get<uint64_t>(PR_START_DATE);
 	auto end_nt   = rq_prop.get<uint64_t>(PR_END_DATE);
 	if (start_nt != nullptr && end_nt != nullptr) {
 		std::vector<freebusy_event> fbdata;
 		auto start_ts = rop_util_nttime_to_unix(*start_nt);
 		auto end_ts   = rop_util_nttime_to_unix(*end_nt);
 		/* XXX: May need PR_SENDER rather than Envelope-From */
-		if (!get_freebusy(par.ev_from, par.cur.dirc(), start_ts, end_ts, fbdata))
+		response_allowed = freebusy_perms(par.ev_from, par.cur.dirc()) != 0;
+		if (!get_freebusy(nullptr, par.cur.dirc(), start_ts, end_ts, fbdata))
 			mlog(LV_ERR, "W-PREC: cannot retrieve freebusy %s", par.cur.dirc());
 
 		for (const freebusy_event &event : fbdata)
@@ -1197,9 +1198,11 @@ static ec_error_t mr_do_request(rxparam &par, const PROPID_ARRAY &propids,
 
 	/* Decline double-booking if so configured */
 	if (res_in_use && policy.decline_overlap) {
-		auto err = mr_send_response(par, recurring_flg, propids, respDeclined);
-		if (err != ecSuccess)
-			return err;
+		if (response_allowed) {
+			auto err = mr_send_response(par, recurring_flg, propids, respDeclined);
+			if (err != ecSuccess)
+				return err;
+		}
 		return mr_mark_done(par);
 	}
 
@@ -1212,9 +1215,11 @@ static ec_error_t mr_do_request(rxparam &par, const PROPID_ARRAY &propids,
 	if (policy.is_resource())
 		return mr_mark_done(par);
 	if (tent == respAccepted) {
-		err = mr_send_response(par, recurring_flg, propids, tent);
-		if (err != ecSuccess)
-			return err;
+		if (response_allowed) {
+			err = mr_send_response(par, recurring_flg, propids, tent);
+			if (err != ecSuccess)
+				return err;
+		}
 		return mr_mark_done(par);
 	}
 	return ecSuccess;