Skip to content

Commit dd94271

Browse files
committed
mh_nsp: check return value of get_user_ids call
CID 1589511: (#1 of 1): Unchecked return value (CHECKED_RETURN) 2. check_return: Calling mysql_adaptor_get_user_ids without checking return value (as is done elsewhere 11 out of 12 times).
1 parent 5ac27c0 commit dd94271

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

exch/mh/nsp.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,8 @@ ec_error_t MhNspContext::getaddressbookurl(std::string *dest) try
390390

391391
if (dest == nullptr)
392392
dest = &std::get<getaddressbookurl_response>(response).server_url;
393-
mysql_adaptor_get_user_ids(auth_info.username, &user_id, nullptr, nullptr);
393+
if (!mysql_adaptor_get_user_ids(auth_info.username, &user_id, nullptr, nullptr))
394+
return ecError;
394395
memset(username1, 0, std::size(username1));
395396
gx_strlcpy(username1, auth_info.username, std::size(username1));
396397
auto token = strchr(username1, '@');

0 commit comments

Comments
 (0)