nsp: passthrough PR_DEPARTMENT_NAME from SQL user table

Since we have effectively abandoned the old AB Departments from
Gromox 0.x with the GAB rewrite, PR_DEPARTMENT_NAME need no longer be
autogenerated either.

Author: fcneuf

doc/exchange_nsp.4gx

@@ -32,12 +32,7 @@ Default: (unspecified)
 .SH Notes
 A number of properties are always synthesized by exchange_nsp and
 never read from any storage; this includes key properties such as
-PR_ENTRYID, PR_RECORD_KEY, etc. The following properties need
-mentioning:
-.IP \(bu 4
-PR_DEPARTMENT: This property is synthesized from the department
-that a user has been assigned to (cf. SQL table "users", column
-"group_id", and SQL table "group", column "title").
+PR_ENTRYID, PR_RECORD_KEY, etc.
 .PP
 For user-attached properties that are read from SQL (cf. table
 "user_properties"), exchange_nsp (as well as zcore(8gx)'s AB) only

doc/user_properties.rst

@@ -23,9 +23,12 @@ possibly transformed by the ABP:
 
 * ``PR_CREATION_TIME``: Not read, but synthesized.
 
-* ``PR_DEPARTMENT_NAME``: Not read, but copied from the ``groups.title``
-  column of the user's group_id. ("groups" in SQL refer to departments, a
-  feature to create hierarchies in the address book).
+* ``PR_DEPARTMENT_NAME``: [Before Gromox 2.42] Not read, but copied from the
+  ``groups.title`` column of the user's group_id. ("groups" in SQL refer to
+  departments, a feature to create hierarchies in the address book). [Since
+  Gromox 2.42] Departments were abandoned and reading the property via MAPI
+  yields no value. [Since Gromox 2.44] Special treatment has ceased. MAPI
+  clients now see the same value as it is in SQL.
 
 * ``PR_DISPLAY_TYPE``: Not read, but synthesized based on PR_DISPLAY_TYPE_EX.
 

exch/nsp/nsp_interface.cpp

@@ -398,9 +398,6 @@ static ec_error_t nsp_interface_fetch_property(const ab_tree::ab_node &node,
 		cu_utf8_to_mb(codepage,
 			dn.c_str(), pprop->value.pstr, temp_len);
 		return ecSuccess;
-	case PR_DEPARTMENT_NAME:
-	case PR_DEPARTMENT_NAME_A:
-		return ecNotFound;
 	case PR_OFFICE_LOCATION:
 		if (!node.company_info(nullptr, &dn))
 			return ecNotFound;