ews: improve types of variables

PT_BOOLEAN requires use of uint8_t (not 32).

Author: jengelh

exch/ews/context.cpp

@@ -2026,7 +2026,7 @@ void EWSContext::toContent(const std::string& dir, tCalendarItem& item, sShape&
 		auto addrType = deconst("SMTP");
 		shape.write(TAGGED_PROPVAL{PR_SENT_REPRESENTING_ADDRTYPE, addrType});
 		shape.write(TAGGED_PROPVAL{PR_SENDER_ADDRTYPE, addrType});
-		auto uint0 = construct<uint32_t>(0);
+		auto uint0 = construct<uint8_t>(0);
 		auto uint1 = construct<uint32_t>(1);
 		auto uint5 = construct<uint32_t>(5);
 		shape.write(NtMeetingType, TAGGED_PROPVAL{PT_LONG, uint1});
@@ -2218,7 +2218,7 @@ void EWSContext::toContent(const std::string& dir, tItem& item, sShape& shape, M
 	if (item.Subject)
 		shape.write(TAGGED_PROPVAL{PR_SUBJECT, deconst(item.Subject->c_str())});
 
-	auto now = EWSContext::construct<uint64_t>(rop_util_current_nttime());
+	auto now = EWSContext::construct<mapitime_t>(rop_util_current_nttime());
 	shape.write(TAGGED_PROPVAL{PR_CREATION_TIME, now});
 	shape.write(TAGGED_PROPVAL{PR_LOCAL_COMMIT_TIME, now});
 
@@ -2406,8 +2406,8 @@ void EWSContext::updated(const std::string& dir, const sMessageEntryId& mid, sSh
 	if (!m_plugin.exmdb.allocate_cn(dir.c_str(), &changeNum))
 		throw DispatchError(E3084);
 	uint64_t localCommitTime = rop_util_current_nttime();
-	shape.write(TAGGED_PROPVAL{PR_LOCAL_COMMIT_TIME, construct<uint64_t>(localCommitTime)});
-	shape.write(TAGGED_PROPVAL{PR_LAST_MODIFICATION_TIME, construct<uint64_t>(localCommitTime)});
+	shape.write(TAGGED_PROPVAL{PR_LOCAL_COMMIT_TIME, construct<mapitime_t>(localCommitTime)});
+	shape.write(TAGGED_PROPVAL{PR_LAST_MODIFICATION_TIME, construct<mapitime_t>(localCommitTime)});
 
 	std::string displayName;
 	if (mysql_adaptor_get_user_displayname(m_auth_info.username,

exch/ews/requests.cpp

@@ -249,7 +249,6 @@ void process(mCreateItemRequest&& request, XMLElement* response, const EWSContex
 		|| request.SendMeetingInvitations == Enum::SendToAllAndSaveCopy;
 
 	data.ResponseMessages.reserve(request.Items.size());
-	auto proptrue = 1;
 	for (sItem &item : request.Items) try {
 		if (!hasAccess)
 			throw EWSError::AccessDenied(E3130);
@@ -268,16 +267,17 @@ void process(mCreateItemRequest&& request, XMLElement* response, const EWSContex
 				sentitems.folderId, &newMid))
 				throw EWSError::InternalServerError(E3132);
 			BOOL result;
-			uint64_t messageId = *(*content).proplist.get<uint64_t>(PidTagMid);
+			auto messageId = *content->proplist.get<const uint64_t>(PidTagMid);
 			if (!ctx.plugin().exmdb.movecopy_message(dir.c_str(), CP_ACP,
 				messageId, sentitems.folderId, newMid, false, &result)
 				|| !result)
 				throw EWSError::InternalServerError(E3301);
 			const char* username = ctx.effectiveUser(sentitems);
 			auto now = EWSContext::construct<uint64_t>(rop_util_current_nttime());
+			static constexpr uint8_t proptrue = 1;
 			TAGGED_PROPVAL props[] = {
 				{PR_MESSAGE_CLASS, deconst("IPM.Schedule.Meeting.Request")},
-				{PR_RESPONSE_REQUESTED, &proptrue},
+				{PR_RESPONSE_REQUESTED, deconst(&proptrue)},
 				{PR_CLIENT_SUBMIT_TIME, now},
 				{PR_MESSAGE_DELIVERY_TIME, now},
 			};