Fix permission requests and lint (#995)

fix permission issues
fix lint

Author: woheller69

app/src/main/java/de/grobox/transportr/AlertService.java

@@ -20,6 +20,7 @@
 package de.grobox.transportr;
 
 import android.Manifest;
+import android.annotation.SuppressLint;
 import android.app.PendingIntent;
 import android.app.Service;
 import static androidx.core.app.NotificationManagerCompat.IMPORTANCE_MAX;
@@ -148,6 +149,14 @@ private void startGpsLocListener() {
 		mLocManager.requestLocationUpdates(LocationManager.GPS_PROVIDER, LOCATION_INTERVAL_MS, 0, this);
 	}
 
+	@SuppressLint("MissingPermission")
+	private void stopGpsLocListener() {
+		if (ActivityCompat.checkSelfPermission(this, Manifest.permission.ACCESS_FINE_LOCATION) != PackageManager.PERMISSION_GRANTED && ActivityCompat.checkSelfPermission(this, Manifest.permission.ACCESS_COARSE_LOCATION) != PackageManager.PERMISSION_GRANTED) {
+			return;
+		}
+		mLocManager.removeUpdates(this);
+	}
+
 	@Override
 	public void onLocationChanged(@NonNull Location location) {
 		lastLocationUpdate = System.currentTimeMillis();
@@ -158,7 +167,7 @@ public void onLocationChanged(@NonNull Location location) {
 			updateNotification(getString(R.string.meter, distanceToDestination) + " / " + timeString , false);
 		} else {
 			updateNotification(null, true);
-			mLocManager.removeUpdates(this);
+			stopGpsLocListener();
 			isWatchdogRunning = false;
 			handler.postDelayed(this::stopSelf, 30000);
 		}
@@ -171,7 +180,7 @@ private void onLocationUpdateTimeout() {
 			updateNotification( timeString , false);
 		} else {
 			updateNotification(null, true);
-			mLocManager.removeUpdates(this);
+			stopGpsLocListener();
 			isWatchdogRunning = false;
 			handler.postDelayed(this::stopSelf, 30000);
 		}
@@ -199,7 +208,7 @@ private void updateNotification(@Nullable String contentText, boolean hasArrived
 	@Override
 	public void onDestroy() {
 		handler.removeCallbacks(watchdogRunnable);
-		mLocManager.removeUpdates(this);
+		stopGpsLocListener();
 		super.onDestroy();
 	}
 }

app/src/main/java/de/grobox/transportr/trips/detail/LegPopupMenu.kt

@@ -27,6 +27,7 @@ import android.content.pm.PackageManager
 import android.os.Build
 import android.view.MenuItem
 import android.view.View
+import android.widget.Toast
 import androidx.core.app.ActivityCompat
 import androidx.core.content.ContextCompat
 import de.grobox.transportr.AlertService
@@ -110,8 +111,18 @@ class LegPopupMenu private constructor(context: Context, anchor: View, location:
         }
     // Alert when close to Leg
         R.id.action_alert ->{
-            if ((Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) && (ActivityCompat.checkSelfPermission(context, Manifest.permission.POST_NOTIFICATIONS) != PackageManager.PERMISSION_GRANTED)){
-                ActivityCompat.requestPermissions(context as Activity, arrayOf(Manifest.permission.POST_NOTIFICATIONS), 0)
+            val permissionsToRequest = mutableListOf<String>()
+            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
+                if (ContextCompat.checkSelfPermission(context, Manifest.permission.POST_NOTIFICATIONS) != PackageManager.PERMISSION_GRANTED) {
+                    permissionsToRequest.add(Manifest.permission.POST_NOTIFICATIONS)
+                }
+            }
+            if (ContextCompat.checkSelfPermission(context, Manifest.permission.ACCESS_FINE_LOCATION) != PackageManager.PERMISSION_GRANTED) {
+                Toast.makeText(context, context.getString(R.string.permission_denied_gps), Toast.LENGTH_LONG).show()
+                permissionsToRequest.add(Manifest.permission.ACCESS_FINE_LOCATION)
+            }
+            if (permissionsToRequest.isNotEmpty()) {
+                ActivityCompat.requestPermissions(context as Activity, permissionsToRequest.toTypedArray(),0)
             } else {
                 val timeStr = time?.let { formatTime(context, it) } ?: "Unknown time"
                 val latitude = loc1.lat / 1000000.0