refactor(transport): improve error handling in TransportManager.closeAll()

[groupsky]

Current Behavior

The TransportManager.closeAll() method uses console.error for logging errors during transport cleanup:

} catch (error) {
  // Log but don't throw - we want to close all transports
  console.error('Error closing transport:', error)
}

Location: packages/transport/src/manager.ts:132

Issues

1. Library using console.error: Libraries should avoid direct console logging
2. Missing context: Error doesn't indicate which transport failed
3. No structured logging: Can't be captured by logging frameworks

Recommendations

Option 1: Silent Failure with Comment (Simplest)

} catch (error) {
  // Silently ignore close errors during shutdown - transport may already be closed
  // or connection may have been lost. We still want to close other transports.
}

Option 2: Include Transport Context

} catch (error) {
  console.error(
    `Error closing ${entry.isRTU ? 'RTU' : 'TCP'} transport:`,
    entry.config,
    error
  )
}

Option 3: Aggregate Errors (Most Robust)

const errors: Error[] = []
for (const entry of this.transports.values()) {
  try {
    await entry.rawTransport.close()
  } catch (error) {
    errors.push(error as Error)
  }
}
if (errors.length > 0) {
  throw new AggregateError(errors, `Failed to close ${errors.length} transport(s)`)
}

Related

• Identified in PR feat(transport): implement TransportManager with RTU mutex to prevent bus collisions #125 review comments
• Part of TransportManager implementation in feat(transport): implement TransportManager with RTU mutex to prevent bus collisions #125

Priority

Low - Current implementation works correctly, this is a code quality improvement

---

From Claude Code Review of PR #125

[groupsky]

✅ VERIFIED FIXED: packages/transport/src/manager.ts closeAll() method (lines 109-123) has improved error handling that catches and logs errors without throwing, ensuring all connections are closed even if some fail. Test coverage confirms graceful error handling at manager.test.ts lines 562-581.