Add test for empty string

Author: arvid-e

packages/remark-lsx/src/server/routes/list-pages/index.spec.ts

@@ -265,10 +265,10 @@ describe('when excludedPaths is handled', () => {
   builderMock.query = queryMock;
 
   beforeEach(() => {
+    vi.clearAllMocks();
     mocks.generateBaseQueryMock.mockResolvedValue(builderMock);
     queryMock.and.mockReturnValue(queryMock);
 
-    // Setup successful flow for count and exec
     const queryClonedMock = mock<PageQuery>();
     queryMock.clone.mockReturnValue(queryClonedMock);
     queryClonedMock.count.mockResolvedValue(0);
@@ -279,45 +279,63 @@ describe('when excludedPaths is handled', () => {
     mocks.getToppageViewersCountMock.mockResolvedValue(0);
   });
 
-  it('does not add path exclusion conditions when excludedPaths is empty', async () => {
-    // setup
+  it('adds a sanitized regex exclusion condition with non-capturing groups', async () => {
     const reqMock = mock<IListPagesRequest>();
     reqMock.query = { pagePath };
     const resMock = mock<Response>();
     resMock.status.mockReturnValue(mock<Response>());
 
-    // excludedPaths is empty
-    const handler = listPages({ excludedPaths: [] });
+    // Includes a path with meta-characters to test sanitization
+    const excludedPaths = ['/user', 'tmp.bak'];
+    const handler = listPages({ excludedPaths });
     await handler(reqMock, resMock);
 
-    // query.and should NOT be called with a $not regex for paths
-    expect(queryMock.and).not.toHaveBeenCalledWith(
-      expect.arrayContaining([
-        expect.objectContaining({
-          path: expect.objectContaining({ $not: expect.any(RegExp) }),
-        }),
-      ]),
-    );
+    // Matches the updated logic: non-capturing groups and escaped dots
+    const expectedRegex = /^\/(?:user|tmp\.bak)(?:\/|$)/;
+    expect(queryMock.and).toHaveBeenCalledWith([
+      {
+        path: { $not: expectedRegex },
+      },
+    ]);
   });
 
-  it('adds a regex exclusion condition when excludedPaths is specified', async () => {
-    // setup
+  it('filters out empty paths to prevent invalid regex or broad exclusion', async () => {
     const reqMock = mock<IListPagesRequest>();
     reqMock.query = { pagePath };
     const resMock = mock<Response>();
     resMock.status.mockReturnValue(mock<Response>());
 
-    // excludedPaths provided
-    const excludedPaths = ['/user', '/tmp'];
+    // Input contains a slash (which becomes empty after cleaning) and an empty string
+    const excludedPaths = ['/', '', '/valid'];
     const handler = listPages({ excludedPaths });
     await handler(reqMock, resMock);
 
-    // check if the logic generates the correct regex: ^\/(user|tmp)(\/|$)
-    const expectedRegex = /^\/(user|tmp)(\/|$)/;
+    // The regex should only contain 'valid'
+    const expectedRegex = /^\/(?:valid)(?:\/|$)/;
+
     expect(queryMock.and).toHaveBeenCalledWith([
       {
         path: { $not: expectedRegex },
       },
     ]);
   });
+
+  it('does not call query.and if all provided excludedPaths are empty strings', async () => {
+    const reqMock = mock<IListPagesRequest>();
+    reqMock.query = { pagePath };
+    const resMock = mock<Response>();
+    resMock.status.mockReturnValue(mock<Response>());
+
+    const handler = listPages({ excludedPaths: ['/', ''] });
+    await handler(reqMock, resMock);
+
+    // Should behave like the empty array case
+    expect(queryMock.and).not.toHaveBeenCalledWith(
+      expect.arrayContaining([
+        expect.objectContaining({
+          path: expect.objectContaining({ $not: expect.any(RegExp) }),
+        }),
+      ]),
+    );
+  });
 });