Skip to content

Commit 5565631

Browse files
authored
balancer/pickfirst: replace grpc.Dial with grpc.NewClient in tests (#7879)
1 parent 634497b commit 5565631

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

balancer/pickfirst/pickfirst_ext_test.go

+9-9
Original file line numberDiff line numberDiff line change
@@ -376,12 +376,12 @@ func (s) TestPickFirst_StickyTransientFailure(t *testing.T) {
376376
},
377377
}),
378378
}
379-
cc, err := grpc.Dial(lis.Addr().String(), dopts...)
379+
cc, err := grpc.NewClient(lis.Addr().String(), dopts...)
380380
if err != nil {
381-
t.Fatalf("Failed to dial server at %q: %v", lis.Addr(), err)
381+
t.Fatalf("Failed to create new client: %v", err)
382382
}
383383
t.Cleanup(func() { cc.Close() })
384-
384+
cc.Connect()
385385
testutils.AwaitState(ctx, t, cc, connectivity.TransientFailure)
386386

387387
// Spawn a goroutine to ensure that the channel stays in TransientFailure.
@@ -837,12 +837,12 @@ func (s) TestPickFirst_ResolverError_WithPreviousUpdate_Connecting(t *testing.T)
837837
grpc.WithResolvers(r),
838838
grpc.WithDefaultServiceConfig(pickFirstServiceConfig),
839839
}
840-
cc, err := grpc.Dial(r.Scheme()+":///test.server", dopts...)
840+
cc, err := grpc.NewClient(r.Scheme()+":///test.server", dopts...)
841841
if err != nil {
842-
t.Fatalf("grpc.Dial() failed: %v", err)
842+
t.Fatalf("grpc.NewClient() failed: %v", err)
843843
}
844844
t.Cleanup(func() { cc.Close() })
845-
845+
cc.Connect()
846846
addrs := []resolver.Address{{Addr: lis.Addr().String()}}
847847
r.UpdateState(resolver.State{Addresses: addrs})
848848
testutils.AwaitState(ctx, t, cc, connectivity.Connecting)
@@ -892,12 +892,12 @@ func (s) TestPickFirst_ResolverError_WithPreviousUpdate_TransientFailure(t *test
892892
grpc.WithResolvers(r),
893893
grpc.WithDefaultServiceConfig(pickFirstServiceConfig),
894894
}
895-
cc, err := grpc.Dial(r.Scheme()+":///test.server", dopts...)
895+
cc, err := grpc.NewClient(r.Scheme()+":///test.server", dopts...)
896896
if err != nil {
897-
t.Fatalf("grpc.Dial() failed: %v", err)
897+
t.Fatalf("grpc.NewClient() failed: %v", err)
898898
}
899899
t.Cleanup(func() { cc.Close() })
900-
900+
cc.Connect()
901901
addrs := []resolver.Address{{Addr: lis.Addr().String()}}
902902
r.UpdateState(resolver.State{Addresses: addrs})
903903
ctx, cancel := context.WithTimeout(context.Background(), defaultTestTimeout)

0 commit comments

Comments
 (0)