Skip to content

Commit 85ede8e

Browse files
authored
transport: Remove unused return value from connect() (#8787)
See: * #8666 (comment) RELEASE NOTES: none Signed-off-by: Tom Wieczorek <[email protected]>
1 parent 9b39ae2 commit 85ede8e

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

clientconn.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -977,25 +977,24 @@ func (cc *ClientConn) incrCallsFailed() {
977977
// connect starts creating a transport.
978978
// It does nothing if the ac is not IDLE.
979979
// TODO(bar) Move this to the addrConn section.
980-
func (ac *addrConn) connect() error {
980+
func (ac *addrConn) connect() {
981981
ac.mu.Lock()
982982
if ac.state == connectivity.Shutdown {
983983
if logger.V(2) {
984984
logger.Infof("connect called on shutdown addrConn; ignoring.")
985985
}
986986
ac.mu.Unlock()
987-
return errConnClosing
987+
return
988988
}
989989
if ac.state != connectivity.Idle {
990990
if logger.V(2) {
991991
logger.Infof("connect called on addrConn in non-idle state (%v); ignoring.", ac.state)
992992
}
993993
ac.mu.Unlock()
994-
return nil
994+
return
995995
}
996996

997997
ac.resetTransportAndUnlock()
998-
return nil
999998
}
1000999

10011000
// equalAddressIgnoringBalAttributes returns true is a and b are considered equal.

0 commit comments

Comments
 (0)