resolving comments

Author: Pranjali-2501

internal/xds/balancer/cdsbalancer/e2e_test/dns_impl_test.go

@@ -1,5 +1,5 @@
 /*
- * Copyright 2025 gRPC authors.
+ * Copyright 2026 gRPC authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

internal/xds/balancer/clusterresolver/configbuilder.go

@@ -154,8 +154,9 @@ func buildClusterImplConfigForDNS(g *nameGenerator, endpoints []resolver.Endpoin
 	}
 	var retEndpoint resolver.Endpoint
 	for _, e := range endpoints {
-		// Copy the nested address field as slice fields are shared by the
-		// iteration variable and the original slice.
+		// LOGICAL_DNS requires all resolved addresses to be grouped into a
+		// single logical endpoint. We iterate over the input endpoints and
+		// aggregate their addresses into a new endpoint variable.
 		retEndpoint.Addresses = append(retEndpoint.Addresses, e.Addresses...)
 	}
 	// Even though localities are not a thing for the LOGICAL_DNS cluster and
@@ -167,7 +168,7 @@ func buildClusterImplConfigForDNS(g *nameGenerator, endpoints []resolver.Endpoin
 	// Set the locality weight to 1. This is required because the child policy
 	// like wrr which relies on locality weights to distribute traffic. These
 	// policies may drop traffic if the weight is 0.
-	retEndpoint = wrrlocality.SetAddrInfoInEndpoint(retEndpoint, wrrlocality.AddrInfo{LocalityWeight: 1})
+	retEndpoint = wrrlocality.SetAddrInfo(retEndpoint, wrrlocality.AddrInfo{LocalityWeight: 1})
 	return pName, lbconfig, []resolver.Endpoint{retEndpoint}
 }
 

internal/xds/balancer/clusterresolver/configbuilder_test.go

@@ -314,7 +314,7 @@ func testEndpointForDNS(endpoints []resolver.Endpoint, localityWeight uint32, pa
 		retEndpoint.Addresses = append(retEndpoint.Addresses, e.Addresses...)
 	}
 	retEndpoint = hierarchy.SetInEndpoint(retEndpoint, path)
-	retEndpoint = wrrlocality.SetAddrInfoInEndpoint(retEndpoint, wrrlocality.AddrInfo{LocalityWeight: localityWeight})
+	retEndpoint = wrrlocality.SetAddrInfo(retEndpoint, wrrlocality.AddrInfo{LocalityWeight: localityWeight})
 	return retEndpoint
 }
 
@@ -363,7 +363,7 @@ func (s) TestBuildClusterImplConfigForDNS(t *testing.T) {
 	} {
 		t.Run(tt.name, func(t *testing.T) {
 			gotName, gotConfig, gotEndpoints := buildClusterImplConfigForDNS(newNameGenerator(3), tt.endpoints, DiscoveryMechanism{Cluster: testClusterName2, Type: DiscoveryMechanismTypeLogicalDNS}, tt.xdsLBPolicy)
-			wantName := "priority-3"
+			const wantName = "priority-3"
 			if diff := cmp.Diff(gotName, wantName); diff != "" {
 				t.Errorf("buildClusterImplConfigForDNS() diff (-got +want) %v", diff)
 			}