Skip to content

Commit 9b366bf

Browse files
committed
Address review feedback
Signed-off-by: iamrajiv <[email protected]>
1 parent 508402d commit 9b366bf

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

credentials/jwt/token_file_call_creds_test.go

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -539,10 +539,14 @@ func (s) TestJWTCallCredentials_E2E(t *testing.T) {
539539
wantErr: "the credentials require transport level security",
540540
},
541541
{
542-
name: "secure_transport_success",
542+
name: "secure_transport_creds_as_dial_option",
543543
useTLS: true,
544544
credsAsDialOpt: true,
545-
wantErr: "",
545+
},
546+
{
547+
name: "secure_transport_creds_as_call_option",
548+
useTLS: true,
549+
credsAsDialOpt: false,
546550
},
547551
}
548552

@@ -574,19 +578,13 @@ func (s) TestJWTCallCredentials_E2E(t *testing.T) {
574578
var serverOpts []grpc.ServerOption
575579
var clientCreds credentials.TransportCredentials
576580
if tt.useTLS {
577-
serverCert, err := tls.LoadX509KeyPair(
578-
testdata.Path("x509/server1_cert.pem"),
579-
testdata.Path("x509/server1_key.pem"),
580-
)
581+
serverCert, err := tls.LoadX509KeyPair(testdata.Path("x509/server1_cert.pem"), testdata.Path("x509/server1_key.pem"))
581582
if err != nil {
582583
t.Fatalf("Failed to load server cert: %v", err)
583584
}
584585
serverOpts = append(serverOpts, grpc.Creds(credentials.NewServerTLSFromCert(&serverCert)))
585586

586-
clientCreds, err = credentials.NewClientTLSFromFile(
587-
testdata.Path("x509/server_ca_cert.pem"),
588-
"x.test.example.com",
589-
)
587+
clientCreds, err = credentials.NewClientTLSFromFile(testdata.Path("x509/server_ca_cert.pem"), "x.test.example.com")
590588
if err != nil {
591589
t.Fatalf("Failed to create client TLS credentials: %v", err)
592590
}

0 commit comments

Comments
 (0)