Skip to content

Commit 71de320

Browse files
committed
Narrow down the scope of the suppression
1 parent 1fcee27 commit 71de320

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

servlet/src/jettyTest/java/io/grpc/servlet/JettyInteropTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
import org.eclipse.jetty.servlet.ServletHolder;
3131
import org.junit.After;
3232

33-
@SuppressWarnings("removal")
3433
public class JettyInteropTest extends AbstractInteropTest {
3534

3635
private static final String HOST = "localhost";
@@ -55,6 +54,9 @@ protected ServerBuilder<?> getServerBuilder() {
5554
}
5655

5756
@Override
57+
// RateControl is deprecated in Jetty 12 (used in grpc-servlet-jakarta) but still needed for
58+
// compatibility with Jetty 10 (used in grpc-servlet).
59+
@SuppressWarnings("removal")
5860
protected void startServer(ServerBuilder<?> builer) {
5961
GrpcServlet grpcServlet =
6062
new GrpcServlet(((ServletServerBuilder) builer).buildServletAdapter());

servlet/src/jettyTest/java/io/grpc/servlet/JettyTransportTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@
4747
import org.junit.Test;
4848

4949

50-
@SuppressWarnings("removal")
5150
public class JettyTransportTest extends AbstractTransportTest {
5251
private static final String MYAPP = "/service";
5352

@@ -57,6 +56,9 @@ public class JettyTransportTest extends AbstractTransportTest {
5756

5857

5958
@Override
59+
// RateControl is deprecated in Jetty 12 (used in grpc-servlet-jakarta) but still needed for
60+
// compatibility with Jetty 10 (used in grpc-servlet).
61+
@SuppressWarnings("removal")
6062
protected InternalServer newServer(List<ServerStreamTracer.Factory> streamTracerFactories) {
6163
return new InternalServer() {
6264
final InternalServer delegate =

0 commit comments

Comments
 (0)