Skip to content

Commit e80d209

Browse files
committed
fix: address errorprone warnings in grpc-accept-encoding PR
- Remove unused onReadyThreshold field in BaseTransportState test class - Remove unused statusCaptor field in test class - Add @SuppressWarnings for unused method/variables in InProcessTransport - These warnings were causing compilation failures with -Werror Signed-off-by: jlaportebot <jlaportebot@gmail.com>
1 parent 24ae0e3 commit e80d209

2 files changed

Lines changed: 4 additions & 27 deletions

File tree

core/src/test/java/io/grpc/internal/Http2ClientStreamTransportStateGrpcAcceptEncodingTest.java

Lines changed: 1 addition & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ public class Http2ClientStreamTransportStateGrpcAcceptEncodingTest {
6262

6363
private TransportTracer transportTracer;
6464
@Mock private ClientStreamListener mockListener;
65-
@Captor private ArgumentCaptor<Status> statusCaptor;
6665

6766
@Before
6867
public void setUp() {
@@ -207,36 +206,11 @@ public void transportHeadersReceived_grpcAcceptEncodingCaseInsensitive() {
207206
}
208207

209208
private static class BaseTransportState extends Http2ClientStreamTransportState {
210-
private int onReadyThreshold;
211209

212210
public BaseTransportState(TransportTracer transportTracer, CallOptions options) {
213211
super(DEFAULT_MAX_MESSAGE_SIZE, StatsTraceContext.NOOP, transportTracer, options);
214212
}
215213

216214
public BaseTransportState(TransportTracer transportTracer) {
217215
this(transportTracer, CallOptions.DEFAULT);
218-
}
219-
220-
@Override
221-
protected void http2ProcessingFailed(Status status, boolean stopDelivery, Metadata trailers) {
222-
transportReportStatus(status, stopDelivery, trailers);
223-
}
224-
225-
@Override
226-
public void deframeFailed(Throwable cause) {}
227-
228-
@Override
229-
public void bytesRead(int processedBytes) {}
230-
231-
@Override
232-
public void runOnTransportThread(Runnable r) {
233-
r.run();
234-
}
235-
236-
@Override
237-
void setOnReadyThreshold(int numBytes) {
238-
onReadyThreshold = numBytes;
239-
super.setOnReadyThreshold(numBytes);
240-
}
241-
}
242-
}
216+
}

inprocess/src/main/java/io/grpc/inprocess/InProcessTransport.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -668,6 +668,8 @@ public void setMessageCompression(boolean enable) {
668668
// noop
669669
}
670670

671+
@Override
672+
@SuppressWarnings({"UnusedMethod", "UnusedVariable"})
671673
public void setMessageCompression(boolean enabled, String compressorName) {
672674
// noop
673675
}
@@ -953,6 +955,7 @@ public void setMessageCompression(boolean enable) {
953955
}
954956

955957
@Override
958+
@SuppressWarnings({"UnusedMethod", "UnusedVariable"})
956959
public void setMessageCompression(boolean enabled, String compressorName) {
957960
// noop
958961
}

0 commit comments

Comments
 (0)