Commit e898755
committed
Address Copilot review items from #4251754607
- Update class Javadoc to reflect 3 tests (was 2)
- Third test: remove misleading isReady toggling since buffering
is triggered by readyAndDrained=false (set after first write),
not by isReady() state. Keep isReady always true to match
the actual scenario being tested.
- Fix comment: 'buffering happens regardless of isReady state'
- Fix inline comment in runOrBuffer flush path: 'subsequent
writes/flushes can go direct without unnecessary buffering'
Reviewed-by: copilot-pull-request-reviewer[bot]
Fixes #127901 parent c73e67a commit e898755
2 files changed
Lines changed: 9 additions & 9 deletions
File tree
- servlet/src
- main/java/io/grpc/servlet
- test/java/io/grpc/servlet
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
223 | 223 | | |
224 | 224 | | |
225 | 225 | | |
226 | | - | |
227 | | - | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
228 | 229 | | |
229 | 230 | | |
230 | 231 | | |
| |||
Lines changed: 6 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
36 | | - | |
37 | | - | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
38 | 39 | | |
39 | 40 | | |
40 | 41 | | |
| |||
154 | 155 | | |
155 | 156 | | |
156 | 157 | | |
157 | | - | |
158 | | - | |
159 | | - | |
| 158 | + | |
| 159 | + | |
160 | 160 | | |
161 | 161 | | |
162 | 162 | | |
| |||
165 | 165 | | |
166 | 166 | | |
167 | 167 | | |
168 | | - | |
169 | 168 | | |
170 | 169 | | |
171 | 170 | | |
| |||
0 commit comments