Skip to content

Commit acbd55d

Browse files
authored
Uncomment StreamPriorityData frames in stream handler tests (#73)
We had TODOs to uncomment some H2 frames in tests when their init became available, which it has. This PR uncomments them.
1 parent 11bb867 commit acbd55d

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

Tests/GRPCNIOTransportCoreTests/Client/GRPCClientStreamHandlerTests.swift

+3-4
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,9 @@ final class GRPCClientStreamHandlerTests: XCTestCase {
4040
let framesToBeIgnored: [HTTP2Frame.FramePayload] = [
4141
.ping(.init(), ack: false),
4242
.goAway(lastStreamID: .rootStream, errorCode: .cancel, opaqueData: nil),
43-
// TODO: uncomment when it's possible to build a `StreamPriorityData`.
44-
// .priority(
45-
// HTTP2Frame.StreamPriorityData(exclusive: false, dependency: .rootStream, weight: 4)
46-
// ),
43+
.priority(
44+
HTTP2Frame.StreamPriorityData(exclusive: false, dependency: .rootStream, weight: 4)
45+
),
4746
.settings(.ack),
4847
.pushPromise(.init(pushedStreamID: .maxID, headers: [:])),
4948
.windowUpdate(windowSizeIncrement: 4),

Tests/GRPCNIOTransportCoreTests/Server/GRPCServerStreamHandlerTests.swift

+3-4
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,9 @@ final class GRPCServerStreamHandlerTests: XCTestCase {
6464
let framesToBeIgnored: [HTTP2Frame.FramePayload] = [
6565
.ping(.init(), ack: false),
6666
.goAway(lastStreamID: .rootStream, errorCode: .cancel, opaqueData: nil),
67-
// TODO: uncomment when it's possible to build a `StreamPriorityData`.
68-
// .priority(
69-
// HTTP2Frame.StreamPriorityData(exclusive: false, dependency: .rootStream, weight: 4)
70-
// ),
67+
.priority(
68+
HTTP2Frame.StreamPriorityData(exclusive: false, dependency: .rootStream, weight: 4)
69+
),
7170
.settings(.ack),
7271
.pushPromise(.init(pushedStreamID: .maxID, headers: [:])),
7372
.windowUpdate(windowSizeIncrement: 4),

0 commit comments

Comments
 (0)