Allow to configure retry policy on a per-task basis // formatting and naming fixes

Author: nishiol

transactionoutbox-core/src/main/java/com/gruelbox/transactionoutbox/RetryPolicyAware.java

@@ -4,16 +4,15 @@
 
 /**
  * Defines a custom retry policy for tasks scheduled in the {@link TransactionOutbox}.
- * <p>
- * Implement this interface in the class that is passed to
- * {@link TransactionOutbox#schedule(Class)} to override the default retry behavior.
- * </p>
+ *
+ * <p>Implement this interface in the class that is passed to {@link
+ * TransactionOutbox#schedule(Class)} to override the default retry behavior.
  */
 public interface RetryPolicyAware {
   /**
    * Determines the wait duration before retrying a failed task.
    *
-   * @param attempt   The current retry attempt (starting from 1).
+   * @param attempt The current retry attempt (starting from 1).
    * @param throwable The exception that caused the failure.
    * @return The duration to wait before the next retry.
    */
@@ -22,10 +21,10 @@ public interface RetryPolicyAware {
   /**
    * Specifies the maximum number of retry attempts before blocking the task.
    *
-   * @param attempt   The current retry attempt (starting from 1).
+   * @param attempt The current retry attempt (starting from 1).
    * @param throwable The exception that caused the failure.
-   * @return The number of attempts after which the task should be blocked.
-   * If the returned value is less than or equal to {@code attempt}, the task is blocked immediately.
+   * @return The number of attempts after which the task should be blocked. If the returned value is
+   *     less than or equal to {@code attempt}, the task is blocked immediately.
    */
   int blockAfterAttempts(int attempt, Throwable throwable);
 }

transactionoutbox-core/src/main/java/com/gruelbox/transactionoutbox/TransactionOutboxImpl.java

@@ -389,18 +389,22 @@ private Instant after(Duration duration) {
   }
 
   private void updateAttemptCount(
-      TransactionOutboxEntry entry, Throwable cause, RetryPolicyAware work) {
+      TransactionOutboxEntry entry, Throwable cause, RetryPolicyAware retryPolicyAware) {
     try {
       entry.setAttempts(entry.getAttempts() + 1);
 
       int blockAfterAttempts =
-          work == null
+          retryPolicyAware == null
               ? this.blockAfterAttempts
-              : work.blockAfterAttempts(entry.getAttempts(), cause);
+              : retryPolicyAware.blockAfterAttempts(entry.getAttempts(), cause);
       Duration waitDuration =
-          work == null ? this.attemptFrequency : work.waitDuration(entry.getAttempts(), cause);
+          retryPolicyAware == null
+              ? this.attemptFrequency
+              : retryPolicyAware.waitDuration(entry.getAttempts(), cause);
 
-      var blocked = (entry.getTopic() == null) && (entry.getAttempts() >= blockAfterAttempts);
+      var blocked =
+          (entry.getTopic() == null || retryPolicyAware != null)
+              && (entry.getAttempts() >= blockAfterAttempts);
       entry.setBlocked(blocked);
       transactionManager.inTransactionThrows(tx -> pushBack(tx, entry, waitDuration));
       listener.failure(entry, cause);