Support telling us what line and what file the error is commig from

[paladox]

Please support telling us which line and which file the error is coming from instead of just showing code and saying the error is in

this number off files. Since if you have a lot of files you wont know which file is doing it.

grunt-jscs and grunt-jsonlint support this.

[paladox]

This should be high priority since without telling you this information everything gets harder to fix the jshint errors.

[vladikoff]

@paladox could you please provide the current and the expected output. Thanks!

[paladox]

@vladikoff

Currently when it lints the file and finds some errors it does this

Actual outcome

19:13:40 Running "jshint:all" (jshint) task
19:13:56
19:13:56
19:13:56 219 | var getDefaultUri = ( function () {
19:13:56 ^ 'getDefaultUri' was used before it was defined.
19:13:56
19:13:56 87 | function ForeignTitle() {
19:13:56 ^ 'ForeignTitle' was used before it was defined.
19:13:56
19:13:56 >> 2 errors in 213 files
19:13:56 Warning: Task "jshint:all" failed.� Use --force to continue.
19:13:56
19:13:56 Aborted due to warnings.

Expected outcome is so it looks a bit like this.

Th19:30:47 Running "jscs:all" (jscs) task

19:31:11 Illegal trailing whitespace at ./resources/src/mediawiki/mediawiki.Uri.js :
19:31:11 144 |
19:31:11 145 | var getDefaultUri;
19:31:11 146 |
19:31:11 ----------^
19:31:11 147 | /**
19:31:11 148 | * Construct a new URI object. Throws error if arguments are illegal/impossible, or
19:31:11 Illegal trailing whitespace at ./resources/src/mediawiki/mediawiki.Uri.js :
19:31:11 218 | }
19:31:11 219 | }
19:31:11 220 |
19:31:11 ----------^
19:31:11 221 | getDefaultUri = ( function () {
19:31:11 222 | // Cache
19:31:11 >> 2 code style errors found!
19:31:11 Warning: Task "jscs:all" failed.� Use --force to continue.

This is how grunt-jscs does it and the expected outcome for this grunt plugin. It shows you the line and file the error is comming form.

[paladox]

So it tells you the file and line the error is in. But it dosent in grunt-contrib-jshint please could this be changed so it can because grunt-jscs does and grunt-jsonlint does.

[rahul-sekhar]

I am also seeing this problem. Previously, this was working fine - I could see what file each error was coming from.

Now I don't see a filename above each error. Suppose I have 4 errors in 2 files out of a total of 15 files. It should say 4 errors in 2 files at the end, but now it says 4 errors in 15 files.

I haven't been able to tie this to a package version. Even on downgrading to 0.11.3 it continues to happen, so perhaps its a dependency version?

[paladox]

It has the line the error is comming from but doesn't tell your the file. Also we should add --> to tell you which piece of the code is actually causing the error please.

[vladikoff]

Previously, this was working fine

Yeah seems like a regression, probably a change in naming. Should be an easy pull request

[paladox]

I tested with 0.11.3 and it dosent work.

So this is supported just the code needs updating.

[paladox]

@vladikoff Could you open the pull since you know how and where to fix it please.

[paladox]

Yes it worked before but it seems to depend on which repo you test for example I am testing it on mediawiki/core which it wont show which file has the error but if I test it in mediawiki/extensions/CollapsibleVector it shows the error in which file.

[stefcameron]

@vladikoff This is definitely a regression. Without the path to the file, the output is pretty much useless. This was working at least in grunt-contrib-jshint version 0.11.3. No longer works in 0.12.0.

[stefcameron]

So here's the offending line: https://github.com/gruntjs/grunt-contrib-jshint/blob/master/tasks/lib/jshint.js#L95

If the ".bold" statement is removed, file paths start showing-up again using the default Grunt reporter.

This is with the latest version (0.12.0). Is see the same line in 0.11.3 code, but strangely it works when I run the plugin from a tree I installed about 3 months ago, but when I force a new tree to install version 0.11.3, the paths don't show-up. AFAIKT, both 0.11.3 trees are using the same code and same dependencies, but it's hard to tell. Obviously, there's still a difference somewhere. Perhaps there's a subtle difference in the many dependencies that grunt 0.4.5 references since those are all using version ranges, so I'm likely using a slightly different grunt in my new tree I just installed vs my old tree?

[vladikoff]

@stefcameron thanks for investigating, checking ...

[vladikoff]

@stefcameron I just reinstalled the modules, I see the file name here if I remove a semicolon somewhere in the file:

tasks/lib/jshint.js below

➜  grunt-contrib-jshint git:(master) ✗ npm test

> grunt-contrib-jshint@0.12.1 test /Users/vladikoff/dev/grunt-contrib-jshint
> grunt test

Running "jshint:allFiles" (jshint) task

   tasks/lib/jshint.js
     96 |        grunt.log.writeln((result.file ? '   ' + result.file : '').bold)
                                                                                 ^ Missing semicolon.

>> 1 error in 4 files
Warning: Task "jshint:allFiles" failed. Use --force to continue.

Aborted due to warnings.
npm ERR! Test failed.  See above for more details.