Add new Terraform bug to TerraforomApplyWithRetry

Note that this bug assumes the terraform template’s “aws_eip” resource
is called “nat”.  This is actually preferable since other aws_eip
resources may not be subject to this race condition.

Author: josh-padnick

terraform/apply.go

@@ -42,6 +42,9 @@ func ApplyAndGetOutputWithRetry(terraformPath string, vars map[string]string, lo
 		if strings.Contains(output, TF_ERROR_DIFFS_DIDNT_MATCH_DURING_APPLY) {
 			logger.Printf("Terraform apply failed with the error '%s'. %s\n", TF_ERROR_DIFFS_DIDNT_MATCH_DURING_APPLY, TF_ERROR_DIFFS_DIDNT_MATCH_DURING_APPLY_MSG)
 			return ApplyAndGetOutput(terraformPath, vars, logger)
+		else if strings.Contains(output, TF_ERROR_EIP_DOES_NOT_HAVE_ATTRIBUTE_ID) {
+			logger.Printf("Terraform apply failed with the error '%s'. %s\n", TF_ERROR_EIP_DOES_NOT_HAVE_ATTRIBUTE_ID, TF_ERROR_EIP_DOES_NOT_HAVE_ATTRIBUTE_ID_MSG)
+			return ApplyAndGetOutput(terraformPath, vars, logger)
 		} else {
 			return output, err
 		}

terraform/constants.go

@@ -4,3 +4,5 @@ package terraform
 const TF_ERROR_DIFFS_DIDNT_MATCH_DURING_APPLY 		= "diffs didn't match during apply"
 const TF_ERROR_DIFFS_DIDNT_MATCH_DURING_APPLY_MSG 	= "This usually indicates a minor Terraform timing bug (https://github.com/hashicorp/terraform/issues/5200) that goes away when you reapply. Retrying terraform apply."
 
+const TF_ERROR_EIP_DOES_NOT_HAVE_ATTRIBUTE_ID		= "Resource 'aws_eip.nat' does not have attribute 'id' for variable 'aws_eip.nat.*.id'"
+const TF_ERROR_EIP_DOES_NOT_HAVE_ATTRIBUTE_ID_MSG 	= "This is a known AWS API eventual consistency issue. See https://github.com/hashicorp/terraform/issues/5335."