spacing, comments and typos

Author: AlexZ005

app/src/main/java/net/gsantner/markor/format/todotxt/TodoTxtActionButtons.java

@@ -359,14 +359,13 @@ private void setPriority(char priority) {
     }
 
     private static Calendar parseDateString(final String dateString, final Calendar fallback) {
-        final String dateFormat = TodoTxtTask.getDateFormat().toPattern();
-        if (dateString == null || dateString.length() != dateFormat.length()) {
+        if (dateString == null || dateString.length() != TodoTxtTask.DATEF_YYYY_MM_DD_LEN) {
             return fallback;
         }
 
         try {
             Calendar calendar = Calendar.getInstance();
-            calendar.setTime(TodoTxtTask.getDateFormat().parse(dateString));
+            calendar.setTime(TodoTxtTask.DATEF_YYYY_MM_DD.parse(dateString));
             return calendar;
         } catch (ParseException e) {
             return fallback;
@@ -385,7 +384,7 @@ private void setDate() {
         final DatePickerDialog.OnDateSetListener listener = (_view, year, month, day) -> {
             Calendar fmtCal = Calendar.getInstance();
             fmtCal.set(year, month, day);
-            final String newDate = TodoTxtTask.getDateFormat().format(fmtCal.getTime());
+            final String newDate = TodoTxtTask.DATEF_YYYY_MM_DD.format(fmtCal.getTime());
             text.replace(sel[0], sel[1], newDate);
         };
 
@@ -404,7 +403,7 @@ private void setDueDate(final int offset) {
         final DatePickerDialog.OnDateSetListener listener = (_view, year, month, day) -> {
             Calendar fmtCal = Calendar.getInstance();
             fmtCal.set(year, month, day);
-            final String newDue = "due:" + TodoTxtTask.getDateFormat().format(fmtCal.getTime());
+            final String newDue = "due:" + TodoTxtTask.DATEF_YYYY_MM_DD.format(fmtCal.getTime());
             runRegexReplaceAction(
                     // Replace due date
                     new ReplacePattern(TodoTxtTask.PATTERN_DUE_DATE, "$1" + newDue + "$4"),

app/src/main/java/net/gsantner/markor/format/todotxt/TodoTxtTask.java

@@ -31,21 +31,28 @@
 public class TodoTxtTask {
 
     //
-    // Static memebers
+    // Static members - date format helpers, regex generators & constants
     //
 
-    public static final String DATE_FORMAT = "yyyy-MM-dd";
+    public static final SimpleDateFormat DATEF_YYYY_MM_DD = new SimpleDateFormat("yyyy-MM-dd", Locale.ROOT);
+    public static final int DATEF_YYYY_MM_DD_LEN = "yyyy-MM-dd".length();
 
+    /**
+     * Returns a SimpleDateFormat for the configured todo date format.
+     * Falls back to {@link #DATE_FORMAT} if settings are not available or the configured pattern is invalid.
+     * Note: This does not cache the SimpleDateFormat instance because the pattern may change at runtime.
+     */
     public static SimpleDateFormat getDateFormat() {
-        final String fmt = ApplicationObject.settings() != null ? ApplicationObject.settings().getTodoDateFormat() : DATE_FORMAT;
+        final String fmt = ApplicationObject.settings() != null ? ApplicationObject.settings().getTodoDateFormat() : "yyyy-MM-dd";
 
         try {
             return new SimpleDateFormat(fmt, Locale.ROOT);
         } catch (IllegalArgumentException e) {
             // Fallback: return a default format instead of throwing
-            return new SimpleDateFormat("yyyy-MM-dd", Locale.ROOT);
+            return DATEF_YYYY_MM_DD;
         }
     }
+
     public static final String PT_DATE = "\\d{4}-\\d{2}-\\d{2}(?:[ T]\\d{2}:\\d{2}(?::\\d{2})?)?";
     public static final Pattern PATTERN_PROJECTS = Pattern.compile("(?:^|\\s)(?:\\++)(\\S+)");
     public static final Pattern PATTERN_CONTEXTS = Pattern.compile("(?:^|\\s)(?:\\@+)(\\S+)");

app/src/main/java/net/gsantner/markor/model/AppSettings.java

@@ -348,7 +348,7 @@ public boolean isTodoAddCompletionDateEnabled() {
     }
 
     public String getTodoDateFormat() {
-        return getString(R.string.pref_key__todotxt__set_date_format, "hh-mm");
+        return getString(R.string.pref_key__todotxt__set_date_format, "yyyy-MM-dd");
     }
 
     public boolean isAppCurrentVersionFirstStart(boolean doSet) {

app/src/main/res/xml/preferences_master.xml

@@ -516,7 +516,7 @@
                     android:summary="@string/add_completion_date_for_todos_when_marking_them_as_done"
                     android:title="@string/add_completion_date" />
                 <ListPreference
-                    android:defaultValue="yyyy-mm-dd"
+                    android:defaultValue="yyyy-MM-dd"
                     android:dialogTitle="@string/theme"
                     android:entries="@array/pref_arrdisp__todo_date_format"
                     android:entryValues="@array/pref_arrkeys__todo_date_format"