tests: add not-found page tests#925
Merged
carlosthe19916 merged 1 commit intoguacsec:mainfrom Feb 18, 2026
Merged
Conversation
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
Contributor
Reviewer's GuideAdds Playwright end-to-end tests to verify the UI Not Found page is rendered for various missing or undefined resources, with one package-related test intentionally skipped due to a known backend limitation. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
43 tasks
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `e2e/tests/ui/pages/not-found/not-found.spec.ts:44-47` </location>
<code_context>
+ await expectNotFound(page);
+ });
+
+ // Enable this test when https://issues.redhat.com/browse/TC-3626 is fixed
+ test.skip("Shows 404 page for non-existent package", async ({ page }) => {
+ await page.goto(`/packages/${NON_EXISTENT_UUID}`);
+ await expectNotFound(page);
</code_context>
<issue_to_address>
**suggestion (testing):** Consider tying the skipped test more explicitly to the external issue or using `test.fixme` for a known-broken scenario
Given this is a known backend issue (TC-3626), consider using `test.fixme` instead of `test.skip`, or annotating it (e.g. `@known-failure`) so it’s clearly surfaced in reports and easier to track/reenable once the backend is fixed.
```suggestion
// FIXME(TC-3626): Backend currently does not return 404 for non-existent package.
// Re-enable once https://issues.redhat.com/browse/TC-3626 is resolved.
test.fixme("Shows 404 page for non-existent package (TC-3626)", async ({ page }) => {
await page.goto(`/packages/${NON_EXISTENT_UUID}`);
await expectNotFound(page);
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #925 +/- ##
==========================================
- Coverage 64.86% 64.14% -0.72%
==========================================
Files 195 195
Lines 3341 3341
Branches 753 753
==========================================
- Hits 2167 2143 -24
- Misses 878 905 +27
+ Partials 296 293 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrrajan
pushed a commit
to mrrajan/trustify-ui
that referenced
this pull request
Mar 2, 2026
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case there are resources non existent or a page not defined in the UI the NotFound Page should be rendered. This PR should cover that scenario
One test is disable on purpose because the rest api for packages does not generate 404 NotFound HTTP response as reported here https://issues.redhat.com/browse/TC-3626
Summary by Sourcery
Add end-to-end coverage for the UI 404 Not Found page across undefined and non-existent resource routes.
Tests: