refactor(helpers): update str_snake function to use hyphen delimiter

- Change the default delimiter in str_snake from underscore to hyphen.
- Remove unused escape_argument function and its related test.
- Clean up code by removing unnecessary comments and imports.

Signed-off-by: guanguans <ityaozm@gmail.com>

Author: guanguans

composer.json

@@ -30,6 +30,7 @@
     "homepage": "https://github.com/guanguans/soar-php",
     "support": {
         "issues": "https://github.com/guanguans/soar-php/issues",
+        "source": "https://github.com/guanguans/soar-php",
         "discussions": "https://github.com/guanguans/soar-php/discussions"
     },
     "funding": [
@@ -121,8 +122,6 @@
             "phpstan/extension-installer": true,
             "symfony/thanks": true
         },
-        "apcu-autoloader": true,
-        "classmap-authoritative": false,
         "optimize-autoloader": true,
         "preferred-install": "dist",
         "sort-packages": true

src/Concerns/HasOptions.php

@@ -416,10 +416,10 @@ public function __call(string $method, array $arguments): mixed
     {
         foreach (['set', 'with', 'get', 'only', 'except'] as $prefix) {
             if (str_starts_with($method, $prefix)) {
-                $name = '-'.str_snake(substr($method, \strlen($prefix)), '-');
-                $actionMethod = $prefix.'Option';
-
-                return $this->{$actionMethod}($name, ...$arguments);
+                return $this->{$prefix.'Option'}(
+                    '-'.str_snake(substr($method, \strlen($prefix))),
+                    ...$arguments
+                );
             }
         }
 
@@ -562,13 +562,11 @@ protected function getNormalizedOptions(): array
      */
     private function normalizeOptions(array $options): array
     {
-        $normalizedOptions = [];
-
         foreach ($options as $name => $value) {
-            $normalizedOptions[$name] = $this->normalizeOption($name, $value);
+            $options[$name] = $this->normalizeOption($name, $value);
         }
 
-        return $normalizedOptions;
+        return $options;
     }
 
     /**

src/Support/helpers.php

@@ -15,7 +15,6 @@
 
 use Composer\Autoload\ClassLoader;
 use Illuminate\Support\Collection;
-use Symfony\Component\Process\Process;
 
 if (!\function_exists('Guanguans\SoarPHP\Support\classes')) {
     /**
@@ -69,34 +68,19 @@ function classes(?callable $filter = null): Collection
     }
 }
 
-if (!\function_exists('Guanguans\SoarPHP\Support\escape_argument')) {
-    /**
-     * Escapes a string to be used as a shell argument.
-     *
-     * @see https://github.com/johnstevenson/winbox-args
-     * @see https://github.com/composer/composer/blob/main/src/Composer/Util/ProcessExecutor.php
-     */
-    function escape_argument(?string $argument): string
-    {
-        return (fn (?string $argument): string => $this->escapeArgument($argument))->call(new Process([]), $argument);
-    }
-}
-
 if (!\function_exists('Guanguans\SoarPHP\Support\str_snake')) {
-    function str_snake(string $value, string $delimiter = '_'): string
+    function str_snake(string $value, string $delimiter = '-'): string
     {
-        $key = $value;
-
         /** @var array<string, array<string, string>> $snakeCache */
         static $snakeCache = [];
+        $key = $value;
 
         if (isset($snakeCache[$key][$delimiter])) {
             return $snakeCache[$key][$delimiter];
         }
 
         if (!ctype_lower($value)) {
             $value = preg_replace('/\s+/u', '', ucwords($value));
-
             $value = mb_strtolower((string) preg_replace('/(.)(?=[A-Z])/u', '$1'.$delimiter, (string) $value), 'UTF-8');
         }
 

tests/Support/HelpersTest.php

@@ -20,7 +20,6 @@
 
 use Illuminate\Support\Collection;
 use function Guanguans\SoarPHP\Support\classes;
-use function Guanguans\SoarPHP\Support\escape_argument;
 use function Guanguans\SoarPHP\Support\str_snake;
 
 it('can get classes', function (): void {
@@ -30,10 +29,6 @@
         ->toHaveCount(2);
 })->group(__DIR__, __FILE__);
 
-it('can escape argument', function (): void {
-    expect(escape_argument('foo bar baz'))->toBeString();
-})->group(__DIR__, __FILE__);
-
 it('can snake string', function (): void {
-    expect(str_snake(__FILE__))->toBe(str(__FILE__)->snake()->toString());
+    expect(str_snake(__FILE__))->toBe(str(__FILE__)->snake('-')->toString());
 })->group(__DIR__, __FILE__);