refactor: Simplify withSudoPassword method signature

- Combine parameters into a single line for better readability
- Maintain functionality while improving code clarity

Author: guanguans

.github/workflows/tests.yml

@@ -30,6 +30,7 @@ jobs:
           php-version: ${{ matrix.php }}
           coverage: xdebug
           # extensions: amqp,apcu,brotli,igbinary,intl,mbstring,memcached,redis,relay,zstd,:php-psr
+          extensions: intl,sodium
         env:
           COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 

rector.dist.php

@@ -34,6 +34,7 @@
 use Rector\CodingStyle\Rector\Enum_\EnumCaseToPascalCaseRector;
 use Rector\CodingStyle\Rector\FuncCall\ArraySpreadInsteadOfArrayMergeRector;
 use Rector\Config\RectorConfig;
+use Rector\DeadCode\Rector\ClassLike\RemoveAnnotationRector;
 use Rector\EarlyReturn\Rector\If_\ChangeOrIfContinueToMultiContinueRector;
 use Rector\EarlyReturn\Rector\Return_\ReturnBinaryOrToEarlyReturnRector;
 use Rector\Php73\Rector\FuncCall\JsonThrowOnErrorRector;
@@ -135,6 +136,10 @@
         ArrowFunctionDelegatingCallToFirstClassCallableRector::class => [
             __DIR__.'/tests/Concerns/HasOptionsTest.php',
         ],
+        RemoveAnnotationRector::class => [
+            __DIR__.'/src/Concerns/HasBinary.php',
+            __DIR__.'/src/Concerns/WithDumpable.php',
+        ],
         SortAssociativeArrayByKeyRector::class => [
             __DIR__.'/benchmarks/',
             __DIR__.'/examples/',

src/Concerns/HasBinary.php

@@ -43,6 +43,9 @@ public function withBinary(string $binary): self
         return $this;
     }
 
+    /**
+     * @codeCoverageIgnore
+     */
     public function defaultBinary(): string
     {
         if (OsHelper::isWindows()) {

src/Concerns/HasSudoPassword.php

@@ -32,10 +32,8 @@ public function withoutSudoPassword(): self
         return $this->withSudoPassword(null);
     }
 
-    public function withSudoPassword(
-        #[\SensitiveParameter]
-        ?string $sudoPassword
-    ): self {
+    public function withSudoPassword(#[\SensitiveParameter] ?string $sudoPassword): self
+    {
         $this->sudoPassword = $sudoPassword;
 
         return $this;

src/Concerns/WithDumpable.php

@@ -21,6 +21,8 @@
 trait WithDumpable
 {
     /**
+     * @codeCoverageIgnore
+     *
      * @noinspection PhpNoReturnAttributeCanBeAddedInspection
      */
     public function dd(mixed ...$args): void
@@ -35,11 +37,8 @@ public function dd(mixed ...$args): void
      */
     public function dump(mixed ...$args): self
     {
-        $args = [$this, ...$args];
-        $varDumperExists = class_exists(VarDumper::class);
-
-        foreach ($args as $arg) {
-            $varDumperExists ? VarDumper::dump($arg) : var_dump($arg);
+        foreach ([$this, ...$args] as $arg) {
+            class_exists(VarDumper::class) ? VarDumper::dump($arg) : var_dump($arg);
         }
 
         return $this;

src/Concerns/WithRunnable.php

@@ -56,7 +56,7 @@ protected function toProcess(): Process
         $command = [$this->binary, ...$this->clone()->getNormalizedOptions()];
 
         $process = $this->shouldApplySudoPassword()
-            ? new Process(command: ['sudo', '-S', ...$command], input: $this->getSudoPassword())
+            ? new Process(command: ['sudo', '-S', ...$command], input: $this->getSudoPassword()) // @codeCoverageIgnore
             : new Process($command);
 
         if ($this->tap instanceof \Closure) {