refactor(WithRunable): Update callable types to Closure for better type safety

- Change callable type hints to Closure for $pipe and $tap properties.
- Update method signatures for withPipe and withTap to accept Closure.
- Ensure type checks use instanceof for Closure instead of is_callable.

Signed-off-by: guanguans <ityaozm@gmail.com>

Author: guanguans

composer.json

@@ -394,7 +394,7 @@
         "rule-doc-generator:rector-validate": "@rule-doc-generator validate src/Support/Rectors/",
         "sk": "@php vendor/bin/swiss-knife --ansi -vv",
         "sk:alice-yaml-fixtures-to-php": "@sk alice-yaml-fixtures-to-php --help",
-        "sk:check-commented-code": "@sk check-commented-code examples/ src/ --line-limit=5 --skip-file=src/Soar.php",
+        "sk:check-commented-code": "@sk check-commented-code examples/ src/ --line-limit=6 --skip-file=src/Soar.php",
         "sk:check-conflicts": "@sk check-conflicts examples/ src/",
         "sk:dump-editorconfig": "@sk dump-editorconfig",
         "sk:finalize-classes": "@sk finalize-classes examples/ src/",

src/Concerns/WithRunable.php

@@ -20,20 +20,20 @@
  */
 trait WithRunable
 {
-    /** @var null|callable(Process): Process */
-    protected $pipe;
+    /** @var null|\Closure(Process): Process */
+    protected ?\Closure $pipe = null;
 
-    /** @var null|callable(Process): void */
-    protected $tap;
+    /** @var null|\Closure(Process): void */
+    protected ?\Closure $tap = null;
 
-    public function withPipe(?callable $pipe): self
+    public function withPipe(?\Closure $pipe): self
     {
         $this->pipe = $pipe;
 
         return $this;
     }
 
-    public function withTap(?callable $tap): self
+    public function withTap(?\Closure $tap): self
     {
         $this->tap = $tap;
 
@@ -59,10 +59,10 @@ protected function toProcess(): Process
             ? new Process(command: ['sudo', '-S', ...$command], input: $this->getSudoPassword())
             : new Process($command);
 
-        if (\is_callable($this->tap)) {
-            ($this->tap)($process);
+        if ($this->tap instanceof \Closure) {
+            $this->tap->call($process, $process);
         }
 
-        return \is_callable($this->pipe) ? ($this->pipe)($process) : $process;
+        return $this->pipe instanceof \Closure ? ($this->pipe)->call($process, $process) : $process;
     }
 }

tests/Concerns/WithRunableTest.php

@@ -62,7 +62,12 @@ protected function shouldApplySudoPassword(): bool
 it('can run soar process with pipe', function (): void {
     expect(Soar::make())
         ->withVersion(true)
-        ->withPipe(static fn (Process $process): Process => $process->setTimeout(3))
+        ->withPipe(function (Process $process): Process {
+            expect($this)->toBeInstanceOf(Process::class);
+            expect($this->commandline)->toBeArray();
+
+            return $process->setTimeout(3);
+        })
         ->run(static function (string $type, string $line): void {
             // dump($type, $line);
         })
@@ -72,7 +77,10 @@ protected function shouldApplySudoPassword(): bool
 it('can run soar process with tap', function (): void {
     expect(Soar::make())
         ->withVersion(true)
-        ->withTap(static function (Process $process): void {
+        ->withTap(function (Process $process): void {
+            expect($this)->toBeInstanceOf(Process::class);
+            expect($this->commandline)->toBeArray();
+
             $process->setTimeout(3);
         })
         ->run(static function (string $type, string $line): void {