fix(SimplifyListIndexRector): Refactor key handling logic

- Improve logic for handling keys in array items
- Use collection methods more efficiently
- Handle null and non-integer keys correctly
- Ensure refactored logic maintains intended functionality and structure

Author: guanguans

phpstan.neon

@@ -66,12 +66,12 @@ parameters:
             message: 'use config() instead'
     ignoreErrors:
         - identifier: argument.templateType
-#        - identifier: binaryOp.invalid
 #        - identifier: cast.string
 #        - identifier: method.nonObject
 #        - identifier: return.void
 #        - identifier: typePerfect.noMixedMethodCaller
         - identifier: argument.type
+        - identifier: binaryOp.invalid
         - identifier: encapsedStringPart.nonString
         - identifier: logicalAnd.resultUnused
         - identifier: missingType.generics

src/Support/Rectors/SimplifyListIndexRector.php

@@ -13,6 +13,7 @@
 
 namespace Guanguans\SoarPHP\Support\Rectors;
 
+use Illuminate\Support\Collection;
 use PhpParser\Node;
 use PhpParser\Node\ArrayItem;
 use PhpParser\Node\Expr;
@@ -69,29 +70,37 @@ public function getNodeTypes(): array
     }
 
     /**
+     * @noinspection ProperNullCoalescingOperatorUsageInspection
+     *
      * @param Array_ $node
      */
     public function refactor(Node $node): ?Node
     {
-        $keys = collect($node->items)->pluck('key');
+        $keys = collect($node->items)
+            ->pluck('key')
+            ->map(fn (?Expr $expr): mixed => $expr instanceof Expr ? $this->valueResolver->getValue($expr) : null);
 
-        if (
-            $keys
-                ->filter(static fn (?Expr $expr): bool => !$expr instanceof Int_)
-                ->isNotEmpty()
-        ) {
+        if ($keys->filter(static fn (mixed $key): bool => null !== $key && !\is_int($key))->isNotEmpty()) {
             return null;
         }
 
-        $keyValues = $keys->mapWithKeys(fn (?Expr $expr): array => [
-            $key = $this->valueResolver->getValue($expr, true) => $key,
-        ]);
+        $finalKeys = $keys->reduce(
+            static fn (Collection $carry, ?int $key): Collection => $carry->put(
+                $key ?? ($carry->isEmpty() ? 0 : $carry->keys()->sortDesc(\SORT_NUMERIC)->first() + 1),
+                $key
+            ),
+            collect()
+        );
 
-        if ($keyValues->count() !== $keys->count() || !$this->isList($keyValues->all())) {
+        if (!$this->isList($finalKeys->all())) {
             return null;
         }
 
-        collect($node->items)->each(static fn (ArrayItem $arrayItem): mixed => $arrayItem->key = null);
+        collect($node->items)->each(static function (ArrayItem $arrayItem): void {
+            if ($arrayItem->key instanceof Int_) {
+                $arrayItem->key = null;
+            }
+        });
 
         return $node;
     }