install ffmpeg to fix CI

Author: guanzo

.github/workflows/ci.yml

@@ -51,6 +51,12 @@ jobs:
       - name: Set SDK_DIR
         run: echo "SDK_DIR=$PWD/renpy-${{ matrix.renpy }}-sdk" >> "$GITHUB_ENV"
 
+      # The video-variant testcases encode with real ffmpeg/ffprobe; the ubuntu
+      # runner images don't ship them, so a job launch fails with OSError errno 2
+      # (the "fix weird layout shift" era of CI failures). Install before run.
+      - name: Install ffmpeg
+        run: sudo apt-get update && sudo apt-get install -y ffmpeg
+
       # The `test` command is uses_display=True and the 7.x leg forces
       # SDL_VIDEODRIVER=x11 -- both need a real X server. xvfb provides it.
       - name: Run testcases

cue_lib/ui/views/video_vfx.rpy

@@ -28,7 +28,7 @@ screen _cue_edit_queue_vbox():
                         "xmark",
                         Function(_cue.video_editor.job_queue.remove, job.job_id),
                         "Remove from queue")
-                text job.filename() + " " + job.speed_label size 11
+                text job.filename() + " " + job.speed_label substitute False size 11
                 text "(" + job.status_text() + ")" size 11
                 if job.status != CueJobStatus.QUEUED:
                     $ _elapsed = int(job.elapsed())
@@ -39,7 +39,10 @@ screen _cue_edit_queue_vbox():
                 hbox:
                     spacing 5
                     null width 20
-                    text job.error_msg size 11 color _cue_color_error
+                    # An ffmpeg failure message (e.g. "[Errno 2] ...") is not
+                    # markup: substituting it would py_eval the brackets and
+                    # crash the whole overlay on every frame.
+                    text job.error_msg substitute False size 11 color _cue_color_error
                     use cue_txt_button("Retry",
                         Function(_cue.video_editor.job_queue.retry, job.job_id))
 

test_game/templates/testcases_legacy.rpy

@@ -541,6 +541,38 @@ testcase click_create_tab_opens_editor:
     $ if not _ok: renpy.quit(status=1)
     $ renpy.quit()
 
+testcase video_queue_error_msg_substitute_guard:
+    $ _cue.is_overlay_visible = True
+    run Jump("start")
+    pause 2.0
+    $ renpy.show("cuevid")
+    pause 1.0
+    $ _cue.video_editor.create(1.5)
+    python:
+        import time as _time
+        _queue = _cue.video_editor.job_queue
+        _deadline = _time.time() + 30.0
+        while _queue.processing and _time.time() < _deadline:
+            _queue.poll()
+            _time.sleep(0.1)
+    # Regression for the CI crash on runners without ffmpeg: a failed encode
+    # sets error_msg to "[Errno 2] ...". The queue text used to be substituted,
+    # so those brackets were py_eval'd and crashed the whole overlay on every
+    # render. Both dynamic text lines are `substitute False` now -- render the
+    # queue with a bracketed error (and bracketed filename) to prove it.
+    $ _cue.video_editor.open_editor()
+    $ _job = _cue.video_editor.job_queue.jobs[-1]
+    $ _job.status = CueJobStatus.ERROR
+    $ _job.vpath = "videos/[bracket] scene.mp4"
+    $ _job.error_msg = "[Errno 2] No such file or directory: 'ffmpeg'"
+    $ renpy.restart_interaction()
+    pause 0.5
+    $ _ok = _job.error_msg == "[Errno 2] No such file or directory: 'ffmpeg'"
+    $ _cue.video_editor.close_editor()
+    $ renpy.restart_interaction()
+    $ if not _ok: renpy.quit(status=1)
+    $ renpy.quit()
+
 testcase video_seamless_transition_preserves_position:
     $ _cue.is_overlay_visible = True
     run Jump("start")

test_game/templates/testcases_modern.rpy

@@ -434,6 +434,30 @@ testcase click_create_tab_opens_editor:
     click "Create"
     assert eval (_cue.video_editor.active)
 
+testcase video_queue_error_msg_substitute_guard:
+    run Jump("start")
+    $ _test.timeout = 10.0
+    run Function(_cue_set_page, CuePage.SFX)
+    $ renpy.show("cuevid")
+    pause 1.0
+    $ _cue.video_editor.create(1.5)
+    pause 0.1 until eval (not _cue.video_editor.job_queue.processing) timeout 30.0
+    # Regression for the CI crash on runners without ffmpeg: a failed encode
+    # sets error_msg to "[Errno 2] ...". The queue text used to be substituted,
+    # so those brackets were py_eval'd and crashed the whole overlay on every
+    # render. Both dynamic text lines are `substitute False` now -- render the
+    # queue with a bracketed error (and bracketed filename) to prove it.
+    $ _cue.video_editor.open_editor()
+    $ _job = _cue.video_editor.job_queue.jobs[-1]
+    $ _job.status = CueJobStatus.ERROR
+    $ _job.vpath = "videos/[bracket] scene.mp4"
+    $ _job.error_msg = "[Errno 2] No such file or directory: 'ffmpeg'"
+    $ renpy.restart_interaction()
+    pause 0.3
+    assert eval (_job.error_msg == "[Errno 2] No such file or directory: 'ffmpeg'")
+    $ _cue.video_editor.close_editor()
+    $ renpy.restart_interaction()
+
 testcase video_seamless_transition_preserves_position:
     run Jump("start")
     $ renpy.show("cuevid")