fix(GuParameterStoreReadPolicy): Remove hard-coded PolicyName

In v64.0.0 `GuParameterStoreReadPolicy` became a singleton scoped to an `App`.

This change stops hard-coding the `PolicyName` property, reverting to AWS default behaviour.
This is because `AWS::IAM::Policy` resources in a CFN stack must have a unique policy name.

Author: akash1810

.changeset/plain-colts-jam.md

@@ -0,0 +1,6 @@
+---
+"@guardian/cdk": minor
+---
+
+Update the `GuParameterStoreReadPolicy` construct to remove the hard-coded `PolicyName` property.
+This allows the `GuParameterStoreReadPolicy` singleton to be instantiated multiple times in a single `GuStack` when there are multiple apps.

src/constructs/iam/policies/parameter-store-read.test.ts

@@ -13,7 +13,6 @@ describe("GuParameterStoreReadPolicy", () => {
     Template.fromStack(stack).resourceCountIs("AWS::IAM::Policy", 1);
 
     Template.fromStack(stack).hasResourceProperties("AWS::IAM::Policy", {
-      PolicyName: "parameter-store-read-policy",
       PolicyDocument: {
         Version: "2012-10-17",
         Statement: [

src/constructs/iam/policies/parameter-store-read.ts

@@ -47,7 +47,6 @@ export class GuParameterStoreReadPolicy extends GuAppAwareConstruct(GuPolicy) {
 
   private constructor(scope: GuStack, props: AppIdentity) {
     super(scope, "ParameterStoreRead", {
-      policyName: "parameter-store-read-policy",
       statements: [new ReadParametersByPath(scope, props), new ReadParametersByName(scope, props)],
       ...props,
     });

src/constructs/iam/roles/__snapshots__/instance-role.test.ts.snap

@@ -192,7 +192,7 @@ exports[`The GuInstanceRole construct should allow additional policies to be spe
           ],
           "Version": "2012-10-17",
         },
-        "PolicyName": "parameter-store-read-policy",
+        "PolicyName": "ParameterStoreReadTesting0F3B634A",
         "Roles": [
           {
             "Ref": "InstanceRoleTestingCB7BD146",
@@ -541,7 +541,7 @@ exports[`The GuInstanceRole construct should be possible to create multiple inst
           ],
           "Version": "2012-10-17",
         },
-        "PolicyName": "parameter-store-read-policy",
+        "PolicyName": "ParameterStoreReadMyfirstappE5C5C329",
         "Roles": [
           {
             "Ref": "InstanceRoleMyfirstapp5C11A22B",
@@ -600,7 +600,7 @@ exports[`The GuInstanceRole construct should be possible to create multiple inst
           ],
           "Version": "2012-10-17",
         },
-        "PolicyName": "parameter-store-read-policy",
+        "PolicyName": "ParameterStoreReadMysecondapp76C0E32C",
         "Roles": [
           {
             "Ref": "InstanceRoleMysecondapp48DD15D7",
@@ -871,7 +871,7 @@ exports[`The GuInstanceRole construct should create an additional logging policy
           ],
           "Version": "2012-10-17",
         },
-        "PolicyName": "parameter-store-read-policy",
+        "PolicyName": "ParameterStoreReadTesting0F3B634A",
         "Roles": [
           {
             "Ref": "InstanceRoleTestingCB7BD146",
@@ -1090,7 +1090,7 @@ exports[`The GuInstanceRole construct should create the correct resources with m
           ],
           "Version": "2012-10-17",
         },
-        "PolicyName": "parameter-store-read-policy",
+        "PolicyName": "ParameterStoreReadTesting0F3B634A",
         "Roles": [
           {
             "Ref": "InstanceRoleTestingCB7BD146",

src/experimental/patterns/__snapshots__/ec2-app.test.ts.snap

@@ -635,7 +635,7 @@ exports[`The GuEc2AppExperimental pattern matches the snapshot 1`] = `
           ],
           "Version": "2012-10-17",
         },
-        "PolicyName": "parameter-store-read-policy",
+        "PolicyName": "ParameterStoreReadTestguec2app072DCDE1",
         "Roles": [
           {
             "Ref": "InstanceRoleTestguec2appC325BE42",

src/experimental/patterns/__snapshots__/gu-load-balanced-app.test.ts.snap

@@ -591,7 +591,7 @@ exports[`the GuLoadBalancedAppExperimental pattern should support all existing G
           ],
           "Version": "2012-10-17",
         },
-        "PolicyName": "parameter-store-read-policy",
+        "PolicyName": "ParameterStoreReadTestguec2app072DCDE1",
         "Roles": [
           {
             "Ref": "InstanceRoleTestguec2appC325BE42",
@@ -1463,7 +1463,7 @@ exports[`the GuLoadBalancedAppExperimental pattern should support all existing G
           ],
           "Version": "2012-10-17",
         },
-        "PolicyName": "parameter-store-read-policy",
+        "PolicyName": "ParameterStoreReadTestgu2D9B3F35",
         "Roles": [
           {
             "Ref": "InstanceRoleTestguD5DB5D23",
@@ -2337,7 +2337,7 @@ exports[`the GuLoadBalancedAppExperimental pattern should support experimental E
           ],
           "Version": "2012-10-17",
         },
-        "PolicyName": "parameter-store-read-policy",
+        "PolicyName": "ParameterStoreReadTestgu2D9B3F35",
         "Roles": [
           {
             "Ref": "InstanceRoleTestguD5DB5D23",
@@ -3519,7 +3519,7 @@ exports[`the GuLoadBalancedAppExperimental pattern should support new ECS and hy
           ],
           "Version": "2012-10-17",
         },
-        "PolicyName": "parameter-store-read-policy",
+        "PolicyName": "ParameterStoreReadTestgu2D9B3F35",
         "Roles": [
           {
             "Ref": "EcsTaskDefinitionTaskRoleB7B6D8DD",

src/patterns/ec2-app/__snapshots__/base.test.ts.snap

@@ -591,7 +591,7 @@ exports[`the GuEC2App pattern can produce a restricted EC2 app locked to specifi
           ],
           "Version": "2012-10-17",
         },
-        "PolicyName": "parameter-store-read-policy",
+        "PolicyName": "ParameterStoreReadTestguec2app072DCDE1",
         "Roles": [
           {
             "Ref": "InstanceRoleTestguec2appC325BE42",
@@ -1463,7 +1463,7 @@ exports[`the GuEC2App pattern should produce a functional EC2 app with minimal a
           ],
           "Version": "2012-10-17",
         },
-        "PolicyName": "parameter-store-read-policy",
+        "PolicyName": "ParameterStoreReadTestguec2app072DCDE1",
         "Roles": [
           {
             "Ref": "InstanceRoleTestguec2appC325BE42",